Page MenuHomeFreeBSD
Differential D47844

syslogd: Fix issues reported by gcc
ClosedPublic
Actions

Authored by markj on Fri, Nov 29, 7:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 4:24 PM
Unknown Object (File)
Wed, Dec 4, 1:29 AM
Unknown Object (File)
Sat, Nov 30, 6:52 PM
Subscribers
imp

Details

Reviewers
jfree
Commits
rGfe291141486a: syslogd: Fix issues reported by gcc
Summary
  • When forwaring a message, don't assume that f->f_num_addr_fds > 0.
  • Avoid calling free() on a stack-allocated object.

Fixes: f4b4a10abb26 ("syslogd: Move selector parsing into its own function")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Fri, Nov 29, 7:52 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 29, 7:52 PM
markj requested review of this revision.Fri, Nov 29, 7:52 PM
Harbormaster completed remote builds in B60880: Diff 147172.Fri, Nov 29, 7:52 PM
jfree accepted this revision.Sat, Nov 30, 4:18 PM
jfree added inline comments.
usr.sbin/syslogd/syslogd.c
1798

I think f_num_addr_fds should always be greater than 0 here (since the filed would be invalid if it didn't have any target addresses), but this certainly does not hurt. LGTM

This revision is now accepted and ready to land.Sat, Nov 30, 4:18 PM
Closed by commit rGfe291141486a: syslogd: Fix issues reported by gcc (authored by markj). · Explain WhySat, Nov 30, 6:53 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGfe291141486a: syslogd: Fix issues reported by gcc.

Revision Contents
Changeset List

PathSize
usr.sbin/
syslogd/
3 lines

Diff 147229

View Options

usr.sbin/syslogd/syslogd.c

Loading...