syslogd: Split up basic test case

[jfree]

Summary

The basic test case was previously used to test if messages are
correctly logged over UNIX, INET, and INET6 transport. This single
case can be split up into three separate tests to decrease code
complexity and offer more granular results.

Both INET and INET6 cases will be skipped if the kernel does not
support the corresponding transport.

[markj]

usr.sbin/syslogd/tests/syslogd_test.sh

158–159

185

185–188

I would suggest calling atf_skip if both inet and inet6 are not set.

[zlei]

usr.sbin/syslogd/tests/syslogd_test.sh

185–188

I would suggest calling atf_skip if both inet and inet6 are not set.

Or maybe it is better to have separate test cases, aka test_unix, test_inet and test_inet6 ?

[jfree]

• Use sysctl's -n flag to print value without variable name. Silly mistake on my part.
• Skip test if INET and INET6 are unsupported by kernel.

[jfree]

Separate the "basic" test into three separate tests:

• unix
• inet
• inet6

Thanks to @zlei for the suggestion.

[zlei]

Looks good to me.

[markj]

usr.sbin/syslogd/tests/syslogd_test.sh

148

Unfortunately, the way this works is that the sysctl simply doesn't exist if the feature isn't there. So you have to write something like:

if [ "$(sysctl -n kern.features.inet)" -ne 1 ]; then
    atf_skip
fi

You might also want to make sure that atf_skip can be used in the test case head. It might be fine, but it should be double-checked if you haven't already.

[jfree]

• Fix sysctl(8) usage
• Do not use atf_skip(3) in test head - it causes failure