Page MenuHomeFreeBSD

Update Mk/Uses/python.mk
Needs ReviewPublic

Authored by sunpoet on Jan 2 2016, 7:50 PM.

Details

Reviewers
sunpoet
eadler
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Python
Summary
  • Update PLIST_SUB:
    • Add PYTHON_PYOEXTENSION and PYTHON_SUFFIX
    • Add PYTHON2 and PYTHON3
    • Respect PYTHON_VERSION
  • Rename PYOEXTENSION to PYTHON_PYOEXTENSION

This change would help:

  • Build databases/postgresql*-plpython with Python 3 (It has PLIST issue since bsd.python.mk to Uses/python.mk transition)
  • Simplify Makefile
% cd /usr/ports/databases/postgresql94-plpython
% make -V PYTHON_VERSION
python3.5
% make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/postgresql/plpython2.so
Error: Missing: %%DATADIR%%/extension/plpython2u--1.0.sql
Error: Missing: %%DATADIR%%/extension/plpython2u--unpackaged--1.0.sql
Error: Missing: %%DATADIR%%/extension/plpython2u.control
Error: Missing: %%DATADIR%%/extension/plpythonu--1.0.sql
Error: Missing: %%DATADIR%%/extension/plpythonu--unpackaged--1.0.sql
Error: Missing: %%DATADIR%%/extension/plpythonu.control
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/databases/postgresql94-plpython
% make -V PLIST_SUB
PYTHON2="" PYTHON3="@comment " PG_USER=pgsql  PG_GROUP=pgsql PYTHON_INCLUDEDIR=include/python3.5m  PYTHON_LIBDIR=lib/python3.5  PYTHON_PLATFORM=freebsd10  PYTHON_SITELIBDIR=lib/python3.5/site-packages  PYTHON_VER=3.5  PYTHON_VERSION=python3.5 OSREL=10.2 PREFIX=%D LOCALBASE=/usr/local  RESETPREFIX=/usr/local PORTDOCS="@comment " PORTEXAMPLES="@comment " LIB32DIR=lib DOCSDIR="share/doc/postgresql"  EXAMPLESDIR="share/examples/postgresql"  DATADIR="share/postgresql"  WWWDIR="www/postgresql"  ETCDIR="etc/postgresql"
Test Plan

exp-run for Mk/Uses/python.mk change

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6508
Build 6737: arc lint + arc unit

Event Timeline

sunpoet updated this revision to Diff 11863.Jan 2 2016, 7:50 PM
sunpoet retitled this revision from to Update Mk/Uses/python.mk.
sunpoet updated this object.
sunpoet edited the test plan for this revision. (Show Details)
sunpoet added reviewers: Python, portmgr, x11, kwm.
sunpoet updated this revision to Diff 11864.Jan 2 2016, 7:53 PM
sunpoet edited edge metadata.

Update for missing databases/postgresql90-plpython/Makefile in previous revision.

sunpoet updated this object.Jan 2 2016, 7:58 PM
sunpoet edited edge metadata.
antoine added a subscriber: antoine.Jan 3 2016, 3:10 PM

Can you adjust the following ports:

accessibility/accerciser
accessibility/orca
accessibility/py3-atspi
astro/weather
deskutils/alacarte
devel/pygobject3-common
devel/py3-gobject3
editors/gedit-plugins
graphics/eog-plugins
graphics/py3-cairo
graphics/py-opencv
?

eadler requested changes to this revision.May 16 2016, 9:18 AM
eadler removed reviewers: portmgr, kwm, x11, Python.
eadler added reviewers: portmgr, kwm, x11, Python.
eadler added a reviewer: eadler.
This revision now requires changes to proceed.May 16 2016, 9:18 AM
sunpoet updated this object.Dec 31 2016, 11:50 AM
sunpoet removed reviewers: x11, kwm.
sunpoet updated this revision to Diff 23491.Dec 31 2016, 3:57 PM
sunpoet edited edge metadata.

Update Mk/Uses/python.mk

sunpoet retitled this revision from Update Mk/Uses/python.mk to Mk/Uses/python.mk: add more PLIST_SUB.Dec 31 2016, 7:21 PM
sunpoet updated this object.
sunpoet edited edge metadata.
sunpoet updated this revision to Diff 23493.Dec 31 2016, 7:21 PM
sunpoet retitled this revision from Mk/Uses/python.mk: add more PLIST_SUB to Update Mk/Uses/python.mk.
sunpoet updated this object.

Mk/Uses/python.mk: add more PLIST_SUB

Owners edited edge metadata.Dec 31 2016, 7:21 PM