p9fs: Use UNLINKAT instead of REMOVE to implement removals
ClosedPublic
Actions

Authored by markj on Mon, Nov 4, 5:26 PM.

Details

Reviewers

dfr
val_packett.cool

Commits

rG1d99e8d9a37e: p9fs: Use UNLINKAT instead of REMOVE to implement removals

Summary

REMOVE doesn't work properly in the face of hard links. Use UNLINKAT
instead, which is implemented by qemu and bhyve and lets the client
specify the name being removed.

PR: 282432

Test Plan

Just manual testing in bhyve. It's a bit tricky to write regression tests without having a socket-based transport, since that'd make it easy to implement a simple server using contrib/lib9p...

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Nov 4, 5:26 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 4, 5:26 PM

markj requested review of this revision.Mon, Nov 4, 5:26 PM

Harbormaster completed remote builds in B60385: Diff 145998.Mon, Nov 4, 5:26 PM

markj edited the test plan for this revision. (Show Details)Mon, Nov 4, 5:28 PM

markj added a reviewer: val_packett.cool.

LGTM - thanks for working on this. I think lib9p can support a socket-based transport which allows for testing lib9p itself. In the kernel there is an attempt at an abstraction layer but I think that its only ever been used with virtio,

This revision is now accepted and ready to land.Wed, Nov 6, 1:04 PM

Closed by commit rG1d99e8d9a37e: p9fs: Use UNLINKAT instead of REMOVE to implement removals (authored by markj). · Explain WhyThu, Nov 7, 6:33 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1d99e8d9a37e: p9fs: Use UNLINKAT instead of REMOVE to implement removals.