Page MenuHomeFreeBSD
Differential D47388

dpaa2_mc: Check for error the first time bus_generic_detach is called
ClosedPublic
Actions

Authored by jhb on Fri, Nov 1, 2:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 10:39 PM
Unknown Object (File)
Wed, Nov 20, 3:54 AM
Unknown Object (File)
Sun, Nov 17, 8:47 PM
Unknown Object (File)
Thu, Nov 14, 2:11 PM
Unknown Object (File)
Thu, Nov 14, 1:00 PM
Unknown Object (File)
Thu, Nov 14, 12:11 PM
Unknown Object (File)
Thu, Nov 14, 5:17 AM
Unknown Object (File)
Tue, Nov 12, 7:09 PM
View All 11 Files
Subscribers
dsl

Details

Reviewers
imp
dsl
Commits
rG24d5a8e6eec2: dpaa2_mc: Check for error the first time bus_generic_detach is called
Summary

This removes the need for the second call.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Fri, Nov 1, 2:21 PM
jhb created this revision.
Harbormaster completed remote builds in B60332: Diff 145851.Fri, Nov 1, 2:21 PM
Herald added a subscriber: dsl. · View Herald TranscriptFri, Nov 1, 2:21 PM
jhb added a parent revision: D47387: Check for errors when detaching children first, not last.Fri, Nov 1, 2:21 PM
jhb added a child revision: D47389: Remove bogus detach routines.
dsl added inline comments.Fri, Nov 1, 10:50 PM
sys/dev/dpaa2/dpaa2_mc.c
286

In case of an error returned by any device_detach() all of the de-allocation below will be skipped. I'd rather log this error instead.

jhb added inline comments.Sat, Nov 2, 1:50 PM
sys/dev/dpaa2/dpaa2_mc.c
286

But you can't just keep going. device_delete_children() is going to fail as well if bus_generic_detach() fails. That means you will still be attached, but will have your state partially destroyed, and child drivers can still call into your driver that now has mostly destroyed state and probably cause a panic. You have to stop if child drivers fail to detach.

dsl accepted this revision.Sat, Nov 2, 7:32 PM
This revision is now accepted and ready to land.Sat, Nov 2, 7:32 PM
Closed by commit rG24d5a8e6eec2: dpaa2_mc: Check for error the first time bus_generic_detach is called (authored by jhb). · Explain WhyTue, Nov 5, 1:34 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG24d5a8e6eec2: dpaa2_mc: Check for error the first time bus_generic_detach is called.

Revision Contents
Changeset List

PathSize
sys/
dev/
dpaa2/
8 lines

Diff 146023

View Options

sys/dev/dpaa2/dpaa2_mc.c

Loading...