Page MenuHomeFreeBSD
Differential D4717

Use m_collapse(9) instead of m_defrag(9) in e1000 drivers
ClosedPublic
Actions

Authored by marius on Dec 28 2015, 12:26 AM.
Tags
None
Referenced Files
F106273830: D4717.diff
Sat, Dec 28, 8:39 AM
F106273741: D4717.diff
Sat, Dec 28, 8:36 AM
Unknown Object (File)
Nov 11 2024, 8:11 AM
Unknown Object (File)
Sep 22 2024, 3:44 AM
Unknown Object (File)
Sep 21 2024, 4:51 PM
Unknown Object (File)
Sep 17 2024, 1:56 PM
Unknown Object (File)
Sep 17 2024, 2:59 AM
Unknown Object (File)
Sep 16 2024, 11:53 AM
View All 57 Files
Subscribers
imp
sbruno

Details

Reviewers
erj
sbruno
Commits
rS293854: Given that em(4), lem(4) and igb(4) hardware doesn't require the
Summary

Given that em(4), lem(4) and igb(4) hardware doesn't require the
alignment guarantees provided by m_defrag(9), use m_collapse(9)
instead for performance reasons.
While at it, sanitize the statistics softc members, i. e. retire
unused ones and add SYSCTL nodes missing for actually used ones.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marius updated this revision to Diff 11728.Dec 28 2015, 12:26 AM
marius retitled this revision from to Use m_collapse(9) instead of m_defrag(9) in e1000 drivers.
marius updated this object.
marius edited the test plan for this revision. (Show Details)
marius added a reviewer: erj.
marius set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptDec 28 2015, 12:26 AM
sbruno accepted this revision.Jan 5 2016, 5:41 PM
sbruno added a reviewer: sbruno.
sbruno added a subscriber: sbruno.

This looks fine and an improvement.

This revision is now accepted and ready to land.Jan 5 2016, 5:41 PM
Closed by commit rS293854: Given that em(4), lem(4) and igb(4) hardware doesn't require the (authored by marius). · Explain WhyJan 13 2016, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
e1000/
7 lines
19 lines
17 lines
12 lines
8 lines
10 lines

Diff 12268

View Options

head/sys/dev/e1000/if_em.h

Loading...
View Options

head/sys/dev/e1000/if_em.c

Loading...
View Options

head/sys/dev/e1000/if_igb.h

Loading...
View Options

head/sys/dev/e1000/if_igb.c

Loading...
View Options

head/sys/dev/e1000/if_lem.h

Loading...
View Options

head/sys/dev/e1000/if_lem.c

Loading...