Paths

Table of Contentst

Differential D46834

sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()
ClosedPublic
Actions

Authored by christos on Sep 28 2024, 3:16 PM.

Tags

None

Referenced Files

	F144448053: D46834.id145090.diff
	Sun, Feb 8, 12:11 PM

	F144314210: D46834.id143867.diff
	Sat, Feb 7, 7:27 PM

	Unknown Object (File)
	Fri, Jan 30, 9:12 PM

	Unknown Object (File)
	Dec 22 2025, 3:37 PM

	Unknown Object (File)
	Dec 7 2025, 5:21 AM

	Unknown Object (File)
	Nov 26 2025, 1:16 AM

	Unknown Object (File)
	Nov 18 2025, 10:16 AM

	Unknown Object (File)
	Nov 4 2025, 4:53 PM

View All 57 Files

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG3b5b485d7436: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()
rGf3092614bcae: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()

Summary

feeder_rate_min functions as the lower boundary.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Sep 28 2024, 3:16 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2024, 3:16 PM

christos requested review of this revision.Sep 28 2024, 3:16 PM

Harbormaster completed remote builds in B59644: Diff 143867.Sep 28 2024, 3:16 PM

christos added inline comments.Sep 28 2024, 3:18 PM

sys/dev/sound/pcm/vchan.c
511	We could just as well use RANGE() to fit the speed into the acceptable range, instead of returning an error.

dev_submerge.ch accepted this revision.Sep 29 2024, 3:08 PM

dev_submerge.ch added inline comments.

sys/dev/sound/pcm/vchan.c
511	I'd prefer the EINVAL return here. The values close to `feeder_rate_min` and `feeder_rate_max` are unrealistic and never used in practice, going out of bounds here is almost certainly a user error.

This revision is now accepted and ready to land.Sep 29 2024, 3:08 PM

markj accepted this revision.Sep 30 2024, 9:05 AM

emaste accepted this revision.Sep 30 2024, 1:10 PM

Closed by commit rGf3092614bcae: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate() (authored by christos). · Explain WhyOct 18 2024, 8:45 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGf3092614bcae: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate().

christos added a commit: rG3b5b485d7436: sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate().Oct 20 2024, 11:22 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

3 lines

Diff 145090

sys/dev/sound/pcm/vchan.c

Loading...