Page MenuHomeFreeBSD

diff3: Fix merge mode.
ClosedPublic

Authored by des on Sep 23 2024, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2025, 12:52 PM
Unknown Object (File)
Feb 9 2025, 12:51 PM
Unknown Object (File)
Feb 9 2025, 11:44 AM
Unknown Object (File)
Feb 3 2025, 2:42 PM
Unknown Object (File)
Jan 18 2025, 7:15 AM
Unknown Object (File)
Jan 18 2025, 1:13 AM
Unknown Object (File)
Jan 12 2025, 8:35 AM
Unknown Object (File)
Dec 30 2024, 7:29 PM
Subscribers

Details

Reviewers
thj
Group Reviewers
Klara
Commits
rGcf73401c4f7a: diff3: Fix merge mode.
Summary

This is mostly thj@'s work, with some tweaks and cleanup by me. There
are still some cases where our output differs from GNU diff3, but it's
much better than before and I'd rather commit what I have now than let
it continue to languish in a metaphorical drawer.

MFC after 3 weeks
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59571
Build 56458: arc lint + arc unit

Event Timeline

des requested review of this revision.Sep 23 2024, 2:51 PM

Looks like an improvement to me, the big comment helps.

Can you bump diff3_version, I think it will help a lot in tracking bug reports.

I would like us to have more tests, but I know how difficult they are to put together.

This revision is now accepted and ready to land.Sep 24 2024, 8:44 AM
This revision was automatically updated to reflect the committed changes.