Split out "Make" changes from D4325 (python.mk mods)

[marino]

Summary

mva@ requested D4325 be split into two sections

[marino]

hi mva@, so how does this split change look?

[marino]

Ping.

I think one of the python makefile is already out of date. Assume that I will fix it before commit.

This diff is very trivial. there's nothing technically wrong with it. This is more of a philosophical review (e.g. it's okay to have version separate from main makefile.)

I know it's holiday period, but it's been a month that I started trying to push reform to python.mk. This is just one part. Hopefully somebody is available to help it along.

[antoine]

I will test this a bit.

Mk/Uses/python.mk

390

Stray ; ?

[antoine]

Except for the stray ";" and the versions that need to be updated, this looks good to me.

[mva]

Looks good to me. Let's just get the outdated file into shape, do an exp-run and commit it.

Cheers
Marcus

[marino]

Resolved conflicts with current tree (removed bitrot and semicolon)

[marino]

Okay, thanks! The diff has been updated, so it's current as of right now.

Mk/Uses/python.mk

390

yeah. Maybe a carry-over from all the Ada code I've been writing lately. I'll remove it in final.

[antoine]

A previous version of the patch was tested at http://package18.nyi.freebsd.org/build.html?mastername=101amd64-default-foo&build=2015-12-28_06h13m17s

[marino]

Thanks, I've committed it. I don't know why the review didn't close automatically though.

For forward work, I'll submit a new review that skips spawning python when it's already known that python is not installed. If it is installed, it will still spawn python as it does now (in other words, nothing is cached by the meta port, it's just another removal of an inefficiency)

[mat]

In D4660#100158, @marino wrote:

Thanks, I've committed it. I don't know why the review didn't close automatically though.

Easy, the Differential Revision line was not the last line of the commit message, you must have reordered the commit template.