debug.sh take advantage of hooks.sh

[sjg]

Summary

Allow Debug{On,Off} to run associated hooks.
This makes it feasible to collect extra debug info at runtime
without needing to modify any potentially verified and hence immutable
scripts.

Like debug.sh, hooks.sh is extremely handy and used extensively
in many parts of Junos and its build environment.
It is provided here in the hope that others may benefit.

We do not dot hooks.sh by default to reduce overhead, but it can
but done from rc.conf et al using

$_HOOKS_SH . /libexec/hooks.sh

to avoid including more than once.

Sponsored by: Juniper Networks, Inc.

[stevek]

libexec/rc/debug.sh

138

Don't you need a dummy "hooks_run" somewhere in the case where dot hooks.sh was not done?

213

Since you're using $local, should this script not sanity check $local somewhere? Something similar to the following perhaps?

case "$local" in
local|:);;
*) local= ;;
esac

libexec/rc/hooks.sh

57

This block doesn't quite look like BSD-2-Clause license.

[sjg]

libexec/rc/debug.sh

138

That what checking for $_HOOKS_SH does, I was trying to keep the overhead down, as you know this stuff gets called a *lot*

213

Yes that's probably a good idea

libexec/rc/hooks.sh

57

Its not, but it is IMO morally equivalent ;-)

[sjg]

Test for $local rather than $isPOSIX_SHELL

[sjg]

_debugShell ensure _TTY is set