Page MenuHomeFreeBSD
Differential D46292

lib/libc/aarch64/string: add strncat SIMD implementation
AcceptedPublic
Actions

Authored by getz on Aug 14 2024, 2:12 PM.
Tags
None
Referenced Files
F103275764: D46292.diff
Fri, Nov 22, 11:08 PM
F103225392: D46292.id142444.diff
Fri, Nov 22, 10:06 AM
Unknown Object (File)
Wed, Nov 13, 3:19 AM
Unknown Object (File)
Fri, Nov 8, 1:15 AM
Unknown Object (File)
Wed, Oct 30, 5:18 PM
Unknown Object (File)
Wed, Oct 30, 1:45 AM
Unknown Object (File)
Thu, Oct 24, 6:10 PM
Unknown Object (File)
Oct 17 2024, 3:28 PM
View All 27 Files
Subscribers
imp

Details

Reviewers
fuz
emaste
andrew
Summary

This patch requires D46170 as it depends on strlcpy being labeled
__memccpy.

It's a direct copy from the amd64 string functions.

Test Plan

Passes all tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59183
Build 56070: arc lint + arc unit

Event Timeline

getz created this revision.Aug 14 2024, 2:12 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 14 2024, 2:12 PM
Herald added a subscriber: imp. · View Herald Transcript
getz requested review of this revision.Aug 14 2024, 2:12 PM
Harbormaster completed remote builds in B59018: Diff 142079.Aug 14 2024, 2:12 PM
getz added a parent revision: D46170: lib/libc/aarch64/string: add memccpy SIMD implementation.Aug 14 2024, 2:12 PM
fuz accepted this revision.Aug 14 2024, 5:11 PM

This looks reasonable.

This revision is now accepted and ready to land.Aug 14 2024, 5:11 PM
getz removed a parent revision: D46170: lib/libc/aarch64/string: add memccpy SIMD implementation.Aug 25 2024, 6:42 PM
getz updated this revision to Diff 142444.Aug 26 2024, 6:02 PM
  • fix Makefile
This revision now requires review to proceed.Aug 26 2024, 6:02 PM
Harbormaster completed remote builds in B59183: Diff 142444.Aug 26 2024, 6:02 PM
andrew added a comment.Sep 22 2024, 6:00 PM

Could this be made machine independent?

fuz added a comment.Sep 23 2024, 9:14 AM

@andrew If we don't have an assembly implementation for memccpy, it's generally faster to implement this function directly.

fuz accepted this revision.Wed, Nov 6, 2:24 PM

exp-run says it's fine.

This revision is now accepted and ready to land.Wed, Nov 6, 2:24 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
string/
4 lines
29 lines

Diff 142444

View Options

lib/libc/aarch64/string/Makefile.inc

Loading...
View Options

lib/libc/aarch64/string/strncat.c

Loading...