filemon: Document how to build into the kernel.
ClosedPublic
Actions

Authored by des on Jul 30 2024, 9:10 AM.

Details

Reviewers

olce
peter
imp

Commits

rG4d7c715bd954: filemon: Document how to build into the kernel.
rG2495f56913fb: filemon: Document how to build into the kernel.
rG057453ffdf57: filemon: Document how to build into the kernel.

Summary

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58887
Build 55774: arc lint + arc unit

Event Timeline

des created this revision.Jul 30 2024, 9:10 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2024, 9:10 AM

des requested review of this revision.Jul 30 2024, 9:10 AM

Harbormaster completed remote builds in B58886: Diff 141563.Jul 30 2024, 9:10 AM

olce accepted this revision.Jul 30 2024, 10:08 AM

olce added a subscriber: olce.

olce added inline comments.

share/man/man4/filemon.4
39–40	I'd rather follow the usual stance for such a device line.

This revision is now accepted and ready to land.Jul 30 2024, 10:08 AM

des marked an inline comment as done.Jul 30 2024, 11:46 AM

des added inline comments.

share/man/man4/filemon.4
39–40	The precedent is about evenly split.

Looks like @peter intended this to be an option, not a device, cf. 6c6f1f0185b84.

This revision now requires review to proceed.Jul 30 2024, 11:50 AM

Harbormaster completed remote builds in B58887: Diff 141564.Jul 30 2024, 11:50 AM

des added a reviewer: peter.Jul 30 2024, 12:05 PM

Doesn't matter. Pick one and be consistent. They are nearly interchangeable usually and 100% the same user experience in this case.

Personally I've always used device because ot feels more natural to me. But beyond that, i think original intent after so long is weak...

This revision is now accepted and ready to land.Jul 30 2024, 4:19 PM

Closed by commit rG057453ffdf57: filemon: Document how to build into the kernel. (authored by des). · Explain WhyJul 30 2024, 7:05 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG057453ffdf57: filemon: Document how to build into the kernel..

des added a commit: rG2495f56913fb: filemon: Document how to build into the kernel..Aug 1 2024, 4:18 PM

des added a commit: rG4d7c715bd954: filemon: Document how to build into the kernel..Aug 1 2024, 4:47 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

filemon.4

4 lines

sys/

conf/

NOTES

3 lines

Diff 141564

View Options

share/man/man4/filemon.4