Page MenuHomeFreeBSD
Differential D45898

sound: Add missing CHN_[UN]LOCKs in sndstat
ClosedPublic
Actions

Authored by christos on Jul 6 2024, 3:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 3, 2:32 PM
Unknown Object (File)
Wed, Apr 29, 8:28 AM
Unknown Object (File)
Wed, Apr 29, 8:22 AM
Unknown Object (File)
Mon, Apr 27, 10:46 AM
Unknown Object (File)
Fri, Apr 24, 8:27 PM
Unknown Object (File)
Fri, Apr 24, 7:16 PM
Unknown Object (File)
Thu, Apr 23, 10:32 PM
Unknown Object (File)
Tue, Apr 21, 3:47 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGfab137d23462: sound: Add missing CHN_[UN]LOCKs in sndstat
rGe850bd36dfda: sound: Add missing CHN_[UN]LOCKs in sndstat
Summary

For sndstat_build_sound4_nvlist(), if we have INVARIANTS or
SND_DIAGNOSTIC enabled, we will hit an lock assertion panic when we call
CHN_GETVOLUME(). Also lock the channel in the sndstat_prepare_pcm() loop
for good measure.

Fixes: bbca3a75bb41 ("sound: Include sound(4) channel information in sndstat nvlist")
Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
8 lines

Diff 140644

View Options

sys/dev/sound/pcm/sndstat.c

Loading...