Page MenuHomeFreeBSD
Differential D45898

sound: Add missing CHN_[UN]LOCKs in sndstat
ClosedPublic
Actions

Authored by christos on Jul 6 2024, 3:05 PM.
Tags
None
Referenced Files
F173514443: D45898.id140621.diff
Sat, Sep 26, 12:29 PM
Unknown Object (File)
Fri, Sep 25, 10:44 PM
Unknown Object (File)
Thu, Sep 24, 7:55 AM
Unknown Object (File)
Wed, Sep 16, 3:33 PM
Unknown Object (File)
Sun, Sep 13, 7:29 AM
Unknown Object (File)
Tue, Sep 8, 11:13 AM
Unknown Object (File)
Wed, Sep 2, 8:54 PM
Unknown Object (File)
Fri, Aug 28, 1:29 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGfab137d23462: sound: Add missing CHN_[UN]LOCKs in sndstat
rGe850bd36dfda: sound: Add missing CHN_[UN]LOCKs in sndstat
Summary

For sndstat_build_sound4_nvlist(), if we have INVARIANTS or
SND_DIAGNOSTIC enabled, we will hit an lock assertion panic when we call
CHN_GETVOLUME(). Also lock the channel in the sndstat_prepare_pcm() loop
for good measure.

Fixes: bbca3a75bb41 ("sound: Include sound(4) channel information in sndstat nvlist")
Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
8 lines

Diff 140644

View Options

sys/dev/sound/pcm/sndstat.c

Loading...