Page MenuHomeFreeBSD
Differential D45875

sx: avoid gcc -Wunused-value
ClosedPublic
Actions

Authored by rlibby on Jul 5 2024, 2:08 AM.
Tags
None
Referenced Files
F147295435: D45875.id140739.diff
Mon, Mar 9, 6:31 PM
F147278268: D45875.id140559.diff
Mon, Mar 9, 3:42 PM
F147208627: D45875.id140559.diff
Mon, Mar 9, 3:26 AM
Unknown Object (File)
Tue, Mar 3, 4:16 PM
Unknown Object (File)
Sat, Feb 21, 3:35 AM
Unknown Object (File)
Tue, Feb 17, 4:12 AM
Unknown Object (File)
Fri, Feb 13, 1:06 AM
Unknown Object (File)
Wed, Feb 11, 3:04 PM
View All Files
Subscribers
None

Details

Reviewers
imp
kib
Commits
rG430be7e1ee71: sx: avoid gcc -Wunused-value

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby requested review of this revision.Jul 5 2024, 2:08 AM
rlibby created this revision.
Harbormaster completed remote builds in B58502: Diff 140559.Jul 5 2024, 2:08 AM
imp added a comment.Jul 5 2024, 2:22 AM

Why didn't sx_lock() complain?

rlibby added a comment.Jul 5 2024, 3:59 AM
In D45875#1045918, @imp wrote:

Why didn't sx_lock() complain?

Oops. It did. I missed it. Will fix. Thanks.

rlibby updated this revision to Diff 140560.Jul 5 2024, 4:24 AM

imp: sx_xlock too

Also fixup whitespace while touching these lines.

Harbormaster completed remote builds in B58503: Diff 140560.Jul 5 2024, 4:24 AM
kib added a comment.Jul 5 2024, 4:44 AM

Then what about sx_try_xlock()?

imp added a comment.Jul 5 2024, 4:49 AM
In D45875#1045923, @kib wrote:

Then what about sx_try_xlock()?

Don't we always test whether that succeeded or not. Otherwise why try??

rlibby added a comment.Jul 5 2024, 4:55 AM

Yeah, we should use the value from sx_try_lock, and we'd like to enforce that it's checked too I guess.

rlibby added a comment.Jul 9 2024, 5:54 PM

Any more input on this one?

kib accepted this revision.Jul 9 2024, 6:28 PM
This revision is now accepted and ready to land.Jul 9 2024, 6:28 PM
Closed by commit rG430be7e1ee71: sx: avoid gcc -Wunused-value (authored by rlibby). · Explain WhyJul 9 2024, 6:46 PM
This revision was automatically updated to reflect the committed changes.
rlibby added a commit: rG430be7e1ee71: sx: avoid gcc -Wunused-value.

Revision Contents
Changeset List

PathSize
sys/
sys/
12 lines

Diff 140739

View Options

sys/sys/sx.h

Loading...