sx: avoid gcc -Wunused-value
ClosedPublic
Actions

Authored by rlibby on Jul 5 2024, 2:08 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 9, 10:49 PM

	Unknown Object (File)
	Sun, Oct 5, 1:58 AM

	Unknown Object (File)
	Thu, Sep 18, 6:00 AM

	Unknown Object (File)
	Thu, Sep 18, 12:46 AM

	Unknown Object (File)
	Wed, Sep 17, 11:35 AM

	Unknown Object (File)
	Wed, Sep 17, 8:03 AM

	Unknown Object (File)
	Mon, Sep 15, 9:54 PM

	Unknown Object (File)
	Mon, Sep 15, 11:34 AM

View All 84 Files

Subscribers

None

Details

Reviewers

imp
kib

Commits

rG430be7e1ee71: sx: avoid gcc -Wunused-value

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby requested review of this revision.Jul 5 2024, 2:08 AM

rlibby created this revision.

Harbormaster completed remote builds in B58502: Diff 140559.Jul 5 2024, 2:08 AM

Why didn't sx_lock() complain?

In D45875#1045918, @imp wrote:

Why didn't sx_lock() complain?

Oops. It did. I missed it. Will fix. Thanks.

imp: sx_xlock too

Also fixup whitespace while touching these lines.

Harbormaster completed remote builds in B58503: Diff 140560.Jul 5 2024, 4:24 AM

Then what about sx_try_xlock()?

In D45875#1045923, @kib wrote:

Then what about sx_try_xlock()?

Don't we always test whether that succeeded or not. Otherwise why try??

Yeah, we should use the value from sx_try_lock, and we'd like to enforce that it's checked too I guess.

Any more input on this one?

kib accepted this revision.Jul 9 2024, 6:28 PM

This revision is now accepted and ready to land.Jul 9 2024, 6:28 PM

Closed by commit rG430be7e1ee71: sx: avoid gcc -Wunused-value (authored by rlibby). · Explain WhyJul 9 2024, 6:46 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG430be7e1ee71: sx: avoid gcc -Wunused-value.

Revision Contents
Changeset List

Path

Size

sys/

sx.h

12 lines

Diff 140739

View Options

sx: avoid gcc -Wunused-valueClosedPublicActions