Remove backwards compatible versions of ifa_ifwithnet and friends

[asomers]

Summary

Revisions 264905 and 266860 added a "int fib" argument to
ifa_ifwithnet and ifa_ifwithdstaddr. For the sake of backwards compatibility,
the new arguments were added to new functions named ifa_ifwithnet_fib and
ifa_ifwithdstaddr_fib, while the old functions became wrappers around the new
ones that passed RT_ALL_FIBS for the fib argument. However, the backwards
compatibility is not desired for FreeBSD 11, because there are numerous other
incompatible changes to the ifnet(9) API. We therefore decided to remove it
from head but leave it in place for stable/9 and stable/10. In addition, this
commit adds the fib argument to ifa_ifwithbroadaddr for consistency's sake.

Test Plan

No functional change is intended. The current behavior can be
tested by the sys/netinet/fibs_test ATF test.

[hrs]

Please bump __FreeBSD_version in sys/sys/param.h, too.

share/man/man9/ifnet.9

1401

This line should be:

is
.Dv RT_ALL_FIBS ,

then ....

sys/net/if_var.h

506 ↗

(On Diff #788)

Is there any specific reason to use u_int for fibnum?

[asomers]

bump __FreeBSD_version and address HRS's comment re RT_ALL_FIBS in ifnet(9)

[asomers]

sys/net/if_var.h

506 ↗

(On Diff #788)

Just because that's the way that its always been, going all the way back to when ifa_ifwithroute_fib was first added in r178888. Just guessing, Julian probably did that because the radix table lower down the stack will panic if fib < 0. Also, the upstack code that calls ifa_ifwithroute_fib all passes u_int's for the fibnum.

[asomers]

Committed as r271438.