Paths

Table of Contentst

Differential D45723

systat: remove gethostby*() calls
Needs ReviewPublic
Actions

Authored by bses30074_gmail.com on Tue, Jun 25, 2:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 27, 5:56 PM

	Unknown Object (File)
	Thu, Jun 27, 4:34 PM

	Unknown Object (File)
	Thu, Jun 27, 4:16 PM

	Unknown Object (File)
	Thu, Jun 27, 3:43 PM

	Unknown Object (File)
	Thu, Jun 27, 2:55 PM

Subscribers

Details

Reviewers

hrs
lwhsu

Summary

Use getaddrinfo to replace gethostbyname.
Use getnameinfo with NI_NAMEREQD flag to replace gethostbyaddr.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	usr.bin/systat/netstat.c:	CHMOD1	Invalid Executable

Unit

No Test Coverage

Build Status

Buildable 58338
Build 55226: arc lint + arc unit

Event Timeline

bses30074_gmail.com created this revision.Tue, Jun 25, 2:21 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 25, 2:21 AM

bses30074_gmail.com requested review of this revision.Tue, Jun 25, 2:21 AM

Harbormaster completed remote builds in B58338: Diff 140200.Tue, Jun 25, 2:21 AM

Fix file permission

Harbormaster completed remote builds in B58339: Diff 140201.Tue, Jun 25, 2:23 AM

bses30074_gmail.com added reviewers: hrs, lwhsu.Tue, Jun 25, 2:24 AM

Update according Hiroki advise in D45594

Use "result" instead of "status" name to store the value of getaddrinfo() function. I don't use "error" because it has already error() function in the code.
Use compound literals instead of "hints" variable.

Harbormaster completed remote builds in B58543: Diff 140649.Sun, Jul 7, 7:41 AM

Remove unused variable

Harbormaster completed remote builds in B58546: Diff 140653.Sun, Jul 7, 10:43 AM

Revise showhosts() for improved efficiency

Harbormaster completed remote builds in B58559: Diff 140674.Mon, Jul 8, 7:55 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

systat/

28 lines

9 lines

Diff 140200

usr.bin/systat/netcmds.c

Loading...

usr.bin/systat/netstat.c

Loading...