Differential D45695

i386 kernel __storeload_barrier: quiet gcc -Warray-bounds
ClosedPublic
Actions

Authored by rlibby on Sat, Jun 22, 5:52 PM.

Tags

None

Referenced Files

	F86942806: D45695.diff
	Thu, Jun 27, 3:39 PM

	Unknown Object (File)
	Tue, Jun 25, 4:02 PM

	Unknown Object (File)
	Mon, Jun 24, 1:49 AM

Subscribers

Details

Reviewers

Commits

rG88478cc02a20: i386 kernel __storeload_barrier: quiet gcc -Warray-bounds

Summary

Use a constant input operand instead of an output operand to tell the
compiler about OFFSETOF_MONITORBUF. If we tell it we are writing to
*(u_int *)OFFSETOF_MONITORBUF, it rightly complains, but we aren't.
The memory clobber already covers the necessary semantics for the
compiler.

Test Plan

No testing done yet! Just following D45694. Will build i386 GENERIC and disassemble membarrier_action_seqcst

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Sat, Jun 22, 5:52 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jun 22, 5:52 PM

rlibby requested review of this revision.Sat, Jun 22, 5:52 PM

Harbormaster completed remote builds in B58308: Diff 140111.Sat, Jun 22, 5:52 PM

rlibby added a parent revision: D45694: amd64 kernel __storeload_barrier: quiet gcc -Warray-bounds.Sat, Jun 22, 5:52 PM

rlibby edited the test plan for this revision. (Show Details)Sat, Jun 22, 5:58 PM

kib accepted this revision.Sun, Jun 23, 2:48 AM

This revision is now accepted and ready to land.Sun, Jun 23, 2:48 AM

Closed by commit rG88478cc02a20: i386 kernel __storeload_barrier: quiet gcc -Warray-bounds (authored by rlibby). · Explain WhyMon, Jun 24, 1:31 AM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG88478cc02a20: i386 kernel __storeload_barrier: quiet gcc -Warray-bounds.

Revision Contents
Changeset List

Path

Size

sys/

i386/

include/

4 lines

Diff 140156

sys/i386/include/atomic.h

Loading...