Page MenuHomeFreeBSD

vtblk: Invoke busdma completion callbacks when polling
Needs ReviewPublic

Authored by markj on Thu, Jun 20, 9:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 26, 12:27 AM
Unknown Object (File)
Tue, Jun 25, 3:31 AM
Unknown Object (File)
Sun, Jun 23, 5:26 PM
Unknown Object (File)
Fri, Jun 21, 4:52 PM
Unknown Object (File)
Fri, Jun 21, 10:25 AM
Unknown Object (File)
Fri, Jun 21, 10:24 AM
Unknown Object (File)
Fri, Jun 21, 8:50 AM
Unknown Object (File)
Fri, Jun 21, 12:45 AM
Subscribers

Details

Reviewers
cperciva
bryanv
Summary

vtblk_poll_request() is used for kernel dumps and for fetching the block
device's identifier string. In the latter case, it was not calling
bus_dmamap_sync() after completing the I/O, but this is required in
general.

Thus:

  • Factor out per-request code from vtblk_queue_completed().
  • Use it in vtblk_poll_request() once virtqueue_poll() finishes.
  • While here, assert that virtqueue_poll() returns the request that we expect.

Reported by: KMSAN
Fixes: 782105f7c898 ("vtblk: Use busdma")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58273
Build 55161: arc lint + arc unit