Page MenuHomeFreeBSD

swap_pager: small improvement to find_least
ClosedPublic

Authored by dougm on Jun 11 2024, 7:38 AM.
Tags
None
Referenced Files
F88555670: D45558.diff
Tue, Jul 16, 12:41 PM
Unknown Object (File)
Sat, Jul 6, 12:55 AM
Unknown Object (File)
Jun 13 2024, 5:37 PM
Unknown Object (File)
Jun 12 2024, 1:56 AM
Unknown Object (File)
Jun 11 2024, 4:49 PM
Subscribers

Details

Summary

This change drops an unneeded test, a branch and avoids a needless computation. Altogether, it saves 10 bytes of instructions on amd64.

It will mean that, on the path to MPASS(0), the same lookup and iteration will happen twice.

Test Plan

The kernel still boots.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 11 2024, 7:38 AM
dougm created this revision.
kib added inline comments.
sys/vm/swap_pager.c
2279
2312

Perhaps it is the time to change these two lines into __unreachable().

This revision is now accepted and ready to land.Jun 11 2024, 2:39 PM
This revision was automatically updated to reflect the committed changes.