Page MenuHomeFreeBSD
Differential D45558

swap_pager: small improvement to find_least
ClosedPublic
Actions

Authored by dougm on Tue, Jun 11, 7:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 5:37 PM
Unknown Object (File)
Wed, Jun 12, 1:56 AM
Unknown Object (File)
Tue, Jun 11, 4:49 PM
Subscribers
imp

Details

Reviewers
kib
Commits
rGdd0e5c02ab13: swap_pager: small improvement to find_least
Summary

This change drops an unneeded test, a branch and avoids a needless computation. Altogether, it saves 10 bytes of instructions on amd64.

It will mean that, on the path to MPASS(0), the same lookup and iteration will happen twice.

Test Plan

The kernel still boots.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Tue, Jun 11, 7:38 AM
dougm created this revision.
kib accepted this revision.Tue, Jun 11, 2:39 PM
kib added inline comments.
sys/vm/swap_pager.c
2279
2312

Perhaps it is the time to change these two lines into __unreachable().

This revision is now accepted and ready to land.Tue, Jun 11, 2:39 PM
Closed by commit rGdd0e5c02ab13: swap_pager: small improvement to find_least (authored by dougm). · Explain WhyTue, Jun 11, 4:39 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGdd0e5c02ab13: swap_pager: small improvement to find_least.
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 11, 4:39 PM
dougm added a reverting change: rG28af3eb62b73: Revert "swap_pager: small improvement to find_least".Sun, Jun 16, 3:39 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
19 lines

Diff 139728

View Options

sys/vm/swap_pager.c

Loading...