LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx()
ClosedPublic
Actions

Authored by bz on Wed, Jun 5, 10:38 PM.

Details

Reviewers

cc
emaste

Commits

rGba0e9f526481: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx()
rG29f9003cbbb3: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx()
rG582469016aed: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx()

Summary

The logic following this new assignment in some cases may not set lsta
but the later tracing is checking for it to be != NULL.
with lsta not initialized that check may not hold up and later we would
dereference lsta->state and possibly panic.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Wed, Jun 5, 10:38 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptWed, Jun 5, 10:38 PM

bz requested review of this revision.Wed, Jun 5, 10:38 PM

Harbormaster completed remote builds in B58078: Diff 139540.Wed, Jun 5, 10:38 PM

emaste accepted this revision.Thu, Jun 6, 3:48 PM

This revision is now accepted and ready to land.Thu, Jun 6, 3:48 PM

Closed by commit rG582469016aed: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx() (authored by bz). · Explain WhyFri, Jun 7, 9:14 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG582469016aed: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx().

bz added a commit: rG29f9003cbbb3: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx().Wed, Jun 12, 4:42 PM

bz added a commit: rGba0e9f526481: LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx().Wed, Jun 12, 7:17 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_80211.c

1 line

Diff 139635

View Options

sys/compat/linuxkpi/common/src/linux_80211.c

LinuxKPI: 802.11: initalize lsta to NULL in linuxkpi_ieee80211_rx()ClosedPublicActions