comm: handle input arguments being NULL
Needs ReviewPublic
Actions

Authored by ccecchi_apple.com on Jun 1 2024, 3:55 PM.

Tags

None

Referenced Files

	F144375946: D45438.id139303.diff
	Sun, Feb 8, 3:16 AM

	Unknown Object (File)
	Fri, Jan 30, 5:48 PM

	Unknown Object (File)
	Wed, Jan 14, 2:13 AM

	Unknown Object (File)
	Dec 24 2025, 1:46 PM

	Unknown Object (File)
	Nov 2 2025, 12:03 AM

	Unknown Object (File)
	Oct 29 2025, 3:01 PM

	Unknown Object (File)
	Oct 29 2025, 2:54 PM

	Unknown Object (File)
	Oct 29 2025, 2:53 PM

View All 52 Files

Subscribers

imp

Details

Reviewers

ache
allanjude

Summary

comm would currently crash when input arguments are NULL.
This commit adds a simple NULL check to prevent that situation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57988
Build 54876: arc lint + arc unit

Event Timeline

ccecchi_apple.com created this revision.Jun 1 2024, 3:55 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2024, 3:55 PM

ccecchi_apple.com requested review of this revision.Jun 1 2024, 3:55 PM

Harbormaster completed remote builds in B57988: Diff 139303.Jun 1 2024, 3:55 PM

ccecchi_apple.com added a child revision: D45439: comm: flush stdout for error checking prior to exiting.Jun 1 2024, 3:56 PM

ccecchi_apple.com added reviewers: ache, allanjude.Jun 1 2024, 4:00 PM

imp added inline comments.Jun 1 2024, 5:26 PM

usr.bin/comm/comm.c
92	How can these be NULL if argc == 2?

Revision Contents
Changeset List

Path

Size

usr.bin/

comm/

comm.c

2 lines

Diff 139303

View Options

comm: handle input arguments being NULLNeeds ReviewPublicActions