Page MenuHomeFreeBSD
Differential D45408

x11/xkbutils: improve comment, add upstream url
ClosedPublic
Actions

Authored by ziaee on May 30 2024, 8:13 AM.
Tags
Referenced Files
Unknown Object (File)
Mon, Dec 8, 2:33 PM
Unknown Object (File)
Sat, Dec 6, 8:51 PM
Unknown Object (File)
Thu, Dec 4, 11:53 AM
Unknown Object (File)
Thu, Dec 4, 11:53 AM
Unknown Object (File)
Wed, Dec 3, 5:09 PM
Unknown Object (File)
Wed, Nov 26, 9:12 AM
Unknown Object (File)
Mon, Nov 17, 12:12 PM
Unknown Object (File)
Mon, Nov 17, 10:55 AM
View All Files
Subscribers
x11

Details

Reviewers
fernape
Group Reviewers
x11
Ports Committers
Commits
R11:c37458d42445: x11/xkbutils: improve comment, add upstream url

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ziaee requested review of this revision.May 30 2024, 8:13 AM
ziaee created this revision.
fernape accepted this revision.May 30 2024, 2:22 PM
This revision is now accepted and ready to land.May 30 2024, 2:22 PM
ziaee updated this revision to Diff 139236.May 30 2024, 8:58 PM
ziaee retitled this revision from x11/xkbutils: list upstream url to x11/xkbutils: improve comment, add upstream url.

Make comment consistent with setxkbmap.

This revision now requires review to proceed.May 30 2024, 8:58 PM
ziaee updated this revision to Diff 139239.May 30 2024, 9:11 PM

improve comment consistency with upstream, except expanded because xkb is already parsed from the name.

fernape added inline comments.Jun 1 2024, 12:01 PM
x11/xkbutils/Makefile
6

COMMENT should begin with a capital, and end without a period

ziaee updated this revision to Diff 139312.Jun 1 2024, 7:03 PM

Capitalize beginning of comment, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2024, 5:03 PM
Closed by commit R11:c37458d42445: x11/xkbutils: improve comment, add upstream url (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.
fernape added a commit: R11:c37458d42445: x11/xkbutils: improve comment, add upstream url.

Revision Contents
Changeset List

PathSize
x11/
xkbutils/
1 line

Diff 139218

View Options

x11/xkbutils/Makefile

Loading...