Page MenuHomeFreeBSD

deprecate ofw_bus_search_compatible, replace with ofw_bus_compatible_lookup
Needs ReviewPublic

Authored by howard0su_gmail.com on Dec 11 2015, 5:36 PM.

Details

Reviewers
imp

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

howard0su_gmail.com retitled this revision from to deprecate ofw_bus_search_compatible, replace with ofw_bus_compatible_lookup.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
howard0su_gmail.com added a reviewer: imp.

Generally, this looks good. Not sure which of these we compile as modules, but It's what we need.

sys/arm/freescale/imx/imx_nop_usbphy.c
95

There's no SIMPLEBUS_PNP_INFO in this file.

sys/arm/ti/omap4/omap4_prcm_clks.c
1409

Nit picky: ocd != NULL

though I know you don't use it elsewhere...

sys/dev/ffec/if_ffec.c
1729

ditto

sys/dev/uart/uart_bus_fdt.c
100

!= NULL

sys/dev/usb/controller/ehci_imx.c
167

Again, no SIMPLEBUS_PNP_INFO line

howard0su_gmail.com edited edge metadata.

Split patch into two patches. this one only contains remove usage of
deprecated function. add pnp_info into a seperate patch.

Address review comments.

Split the change to add PNPINFO to a separate patch.

mark done of the comments.