resolv
ClosedPublic
Actions

Authored by ngie on Dec 11 2015, 5:20 PM.

Details

Reviewers

vangyzen
ume

Commits

rS292431: MFstable/10 r292430:
rS292430: MFC r292250:
rS292250: Allow users override `DEBUG` on the command line via DEBUG_FLAGS="-DDEBUG" with

Summary

Let DEBUG be overridden on the command line with lib/libc/resolv

I ran into compilation issues when trying to do make DEBUG_FLAGS="-g -O0 -DDEBUG"
with libc because the definitions mismatched (nothing vs #defined as 1).

This fixes the issues in lib/libc/resolv with duplicate definitions

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie updated this revision to Diff 11137.Dec 11 2015, 5:20 PM

ngie retitled this revision from to Disable explicit DEBUG #define in lib/libc/resolv.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: ume.

ngie added subscribers: vangyzen, jilles.

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2015, 5:20 PM

No, please don't do that. It looses the feature of the resolver. You should change as follows like NetBSD did:

#ifndef DEBUG
#define DEBUG
#endif

ngie retitled this revision from Disable explicit DEBUG #define in lib/libc/resolv to Let DEBUG be overridden on the command line with lib/libc/resolv.Dec 13 2015, 3:24 AM

ngie updated this object.

ngie edited edge metadata.