sound: Fix oss_sysinfo->numcards
ClosedPublic
Actions

Authored by christos on May 8 2024, 10:46 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGa0ff4e0f3e02: sound: Fix oss_sysinfo->numcards
rG2b3698288771: sound: Fix oss_sysinfo->numcards
rG59d98edae3e1: sound: Fix oss_sysinfo->numcards

Summary

According to the OSS manual, oss_sysinfo->numcards holds the number of
detected audio devices in the system, while the current ncards variable,
whose value is assigned to oss_sysinfo->numcards, holds the number of
registered devices only.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.May 8 2024, 10:46 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 8 2024, 10:46 PM

christos requested review of this revision.May 8 2024, 10:46 PM

Harbormaster completed remote builds in B57628: Diff 138273.May 8 2024, 10:47 PM

This is supposed to be for diagnostic tools only, so it shouldn't really matter much. Assuming we refer to a card by index anywhere (in dmesg, say) it makes sense for numcards to report the highest card number -- OK.

This revision is now accepted and ready to land.May 9 2024, 2:22 PM

dev_submerge.ch accepted this revision.May 9 2024, 4:03 PM

dev_submerge.ch mentioned this in D45135: sound: Remove nmix variable from mixer_oss_mixerinfo().May 9 2024, 5:47 PM

Closed by commit rG59d98edae3e1: sound: Fix oss_sysinfo->numcards (authored by christos). · Explain WhyMay 9 2024, 7:09 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG59d98edae3e1: sound: Fix oss_sysinfo->numcards.

christos added a commit: rG2b3698288771: sound: Fix oss_sysinfo->numcards.May 17 2024, 7:34 PM

christos added a commit: rGa0ff4e0f3e02: sound: Fix oss_sysinfo->numcards.May 22 2024, 1:23 PM