Paths

Table of Contentst

libdiff: Fix type issues.
ClosedPublic
Actions

Authored by des on May 3 2024, 11:54 AM.

Details

Reviewers

allanjude
markj

Group Reviewers

Klara

Commits

rG0549218b43f0: libdiff: Fix type issues.

Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 3 2024, 11:54 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2024, 11:54 AM

des requested review of this revision.May 3 2024, 11:54 AM

Harbormaster completed remote builds in B57566: Diff 138099.May 3 2024, 11:54 AM

allanjude accepted this revision as: allanjude.May 3 2024, 1:26 PM

This revision is now accepted and ready to land.May 3 2024, 1:26 PM

markj added a subscriber: markj.May 3 2024, 1:58 PM

markj added inline comments.

contrib/libdiff/lib/diff_main.c
177	Why does `r` have type `ssize_t` at all? It looks like it should be `int`, as that's what `read_at()` and `buf_cmp()` return.

des added inline comments.May 3 2024, 2:53 PM

contrib/libdiff/lib/diff_main.c
177	good point, I'll change it

avoid unnecessary casts

This revision now requires review to proceed.May 3 2024, 2:55 PM

Harbormaster completed remote builds in B57571: Diff 138108.May 3 2024, 2:55 PM

des marked an inline comment as done.May 3 2024, 2:55 PM

markj accepted this revision as: markj.May 3 2024, 2:57 PM

This revision is now accepted and ready to land.May 3 2024, 2:57 PM

Closed by commit rG0549218b43f0: libdiff: Fix type issues. (authored by des). · Explain WhyMay 3 2024, 3:04 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG0549218b43f0: libdiff: Fix type issues..

Revision Contents
Changeset List

Path

Size

contrib/

libdiff/

lib/

diff_main.c

5 lines

Diff 138109

View Options

contrib/libdiff/lib/diff_main.c

libdiff: Fix type issues.ClosedPublicActions