Page MenuHomeFreeBSD
Differential D45014

sound: Use nitems() where possible
ClosedPublic
Actions

Authored by christos on Mon, Apr 29, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 9:47 PM
Unknown Object (File)
Thu, May 2, 4:12 AM
Unknown Object (File)
Tue, Apr 30, 10:41 PM
Unknown Object (File)
Tue, Apr 30, 2:10 PM
Unknown Object (File)
Tue, Apr 30, 2:09 PM
Unknown Object (File)
Tue, Apr 30, 7:56 AM
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG00b0cbf98bb7: sound: Use nitems() where possible
rGc597c5579232: sound: Use nitems() where possible
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Mon, Apr 29, 4:22 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Apr 29, 4:22 PM
christos requested review of this revision.Mon, Apr 29, 4:22 PM
Harbormaster completed remote builds in B57449: Diff 137847.Mon, Apr 29, 4:22 PM
emaste accepted this revision.Mon, Apr 29, 5:12 PM
emaste added inline comments.
sys/dev/sound/pcm/feeder_format.c
124

this could be updated to size_t while here

276

and here

289

and here

This revision is now accepted and ready to land.Mon, Apr 29, 5:12 PM
markj accepted this revision.Tue, Apr 30, 12:10 AM

Indeed, it's nicer to use unsigned types (unsigned int or size_t) for comparisons with nitems().

christos marked 3 inline comments as done.Tue, Apr 30, 12:30 AM
Closed by commit rGc597c5579232: sound: Use nitems() where possible (authored by christos). · Explain WhyMon, May 6, 6:38 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGc597c5579232: sound: Use nitems() where possible.
christos added a commit: rG00b0cbf98bb7: sound: Use nitems() where possible.Fri, May 17, 7:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
4 lines
hda/
11 lines
4 lines
4 lines
pcm/
4 lines
15 lines
4 lines
2 lines
4 lines
5 lines

Diff 138178

View Options

sys/dev/sound/pci/atiixp.c

Loading...
View Options

sys/dev/sound/pci/hda/hdaa.c

Loading...
View Options

sys/dev/sound/pci/ich.c

Loading...
View Options

sys/dev/sound/pci/maestro3.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/feeder_format.c

Loading...
View Options

sys/dev/sound/pcm/feeder_matrix.c

Loading...
View Options

sys/dev/sound/pcm/feeder_volume.c

Loading...
View Options

sys/dev/sound/pcm/mixer.c

Loading...
View Options

sys/dev/sound/pcm/sound.c

Loading...