Page MenuHomeFreeBSD
Differential D44886

ktrace: Describe CAPFAIL trace point in man page
ClosedPublic
Actions

Authored by jfree on Apr 20 2024, 5:44 PM.
Tags
None
Referenced Files
F133488784: D44886.id137442.diff
Sun, Oct 26, 4:14 AM
F133448660: D44886.diff
Sat, Oct 25, 9:23 PM
Unknown Object (File)
Wed, Oct 15, 4:39 AM
Unknown Object (File)
Wed, Oct 15, 4:39 AM
Unknown Object (File)
Wed, Oct 15, 4:38 AM
Unknown Object (File)
Wed, Oct 15, 4:38 AM
Unknown Object (File)
Tue, Oct 14, 7:07 PM
Unknown Object (File)
Tue, Oct 14, 12:03 AM
View All 65 Files
Subscribers
imp
jonathan

Details

Reviewers
markj
Commits
rG5757a523dc34: ktrace: Describe CAPFAIL trace point in man page
rG4f2ada0d8821: ktrace: Describe CAPFAIL trace point in man page
Summary

Update the ktrace(1) man page to describe the recently improved
capability failure tracing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jfree created this revision.Apr 20 2024, 5:44 PM
Herald added subscribers: jonathan, imp. · View Herald TranscriptApr 20 2024, 5:44 PM
jfree requested review of this revision.Apr 20 2024, 5:44 PM
Harbormaster completed remote builds in B57247: Diff 137442.Apr 20 2024, 5:44 PM
jfree added a child revision: D44887: ktrace: Remove CAPFAIL from default trace points.Apr 20 2024, 5:45 PM
markj added inline comments.Apr 21 2024, 3:05 PM
usr.bin/ktrace/ktrace.1
159

You should reference capsicum.4 here somehow.

161

This wording is a bit confusing to me: I think it could be simplified with something like, "Violations are logged regardless of whether the process has actually entered capability mode."

165

Maybe note that it's more useful when combined with "c".

167

Well, the number of log entries is a pretty weak indicator.

jfree updated this revision to Diff 137476.Apr 22 2024, 3:34 AM
jfree marked 4 inline comments as done.

Address Mark's comments

markj accepted this revision.Apr 22 2024, 1:26 PM

Nice, looks good.

This revision is now accepted and ready to land.Apr 22 2024, 1:26 PM
Closed by commit rG4f2ada0d8821: ktrace: Describe CAPFAIL trace point in man page (authored by jfree). · Explain WhyApr 24 2024, 12:29 AM
This revision was automatically updated to reflect the committed changes.
jfree added a commit: rG4f2ada0d8821: ktrace: Describe CAPFAIL trace point in man page.
jfree added a commit: rG5757a523dc34: ktrace: Describe CAPFAIL trace point in man page.May 12 2024, 12:09 AM

Revision Contents
Changeset List

PathSize
usr.bin/
ktrace/
20 lines

Diff 137590

View Options

usr.bin/ktrace/ktrace.1

Loading...