Page MenuHomeFreeBSD
Differential D44882

kasan: wrap kstack cleanup into a helper
AbandonedPublic
Actions

Authored by khng on Fri, Apr 19, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 2:13 PM
Unknown Object (File)
Fri, Apr 26, 3:53 PM
Unknown Object (File)
Fri, Apr 26, 3:50 PM
Unknown Object (File)
Fri, Apr 26, 3:50 PM
Unknown Object (File)
Fri, Apr 26, 3:50 PM
Unknown Object (File)
Fri, Apr 26, 10:32 AM
Unknown Object (File)
Wed, Apr 24, 9:40 AM
Unknown Object (File)
Mon, Apr 22, 5:45 PM
View All 9 Files
Subscribers
imp
olce

Details

Reviewers
markj
Summary

MFC with: 68a3a7fc9483
MFC after: 3 days
Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57251
Build 54139: arc lint + arc unit

Event Timeline

khng created this revision.Fri, Apr 19, 10:29 PM
Herald added subscribers: olce, imp. · View Herald TranscriptFri, Apr 19, 10:29 PM
khng requested review of this revision.Fri, Apr 19, 10:29 PM
Harbormaster completed remote builds in B57240: Diff 137426.Fri, Apr 19, 10:29 PM
khng updated this revision to Diff 137428.Fri, Apr 19, 10:42 PM

.

Harbormaster completed remote builds in B57242: Diff 137428.Fri, Apr 19, 10:42 PM
markj added inline comments.Sat, Apr 20, 2:54 PM
sys/kern/subr_asan.c
434

I'd prefer a more generic name, like kasan_kstack_init().

Or, follow the pattern of KMSAN and have kasan_thread_alloc() which only zeros the shadow of the stack (if td->td_kstack != 0).

khng updated this revision to Diff 137447.Sat, Apr 20, 9:28 PM

Adapt markj@'s suggestions.

Harbormaster completed remote builds in B57251: Diff 137447.Sat, Apr 20, 9:28 PM
khng marked an inline comment as done.Sat, Apr 20, 9:29 PM
markj added inline comments.Sun, Apr 21, 3:16 PM
sys/kern/subr_asan.c
434

Sorry, by "follow the pattern of KMSAN" I meant that kmsan_thread_alloc() and kasan_thread_alloc() calls should be in the same place. Otherwise it's rather confusing.

We can actually remove the shadow space marking in vm_thread_new() as well. I posted a diff to this effect: https://reviews.freebsd.org/D44891

khng abandoned this revision.Sun, Apr 21, 4:52 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines
10 lines
sys/
4 lines
vm/
2 lines

Diff 137447

View Options

sys/kern/kern_fork.c

Loading...
View Options

sys/kern/subr_asan.c

Loading...
View Options

sys/sys/asan.h

Loading...
View Options

sys/vm/vm_glue.c

Loading...