Page MenuHomeFreeBSD

kasan: wrap kstack cleanup into a helper
AbandonedPublic

Authored by khng on Apr 19 2024, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 5:36 AM
Unknown Object (File)
Fri, Oct 10, 12:41 AM
Unknown Object (File)
Fri, Sep 26, 5:36 AM
Unknown Object (File)
Mon, Sep 22, 11:10 PM
Unknown Object (File)
Mon, Sep 22, 8:24 AM
Unknown Object (File)
Sep 13 2025, 2:50 PM
Unknown Object (File)
Sep 11 2025, 8:45 PM
Unknown Object (File)
Sep 9 2025, 10:36 PM
Subscribers

Details

Reviewers
markj
Summary

MFC with: 68a3a7fc9483
MFC after: 3 days
Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57251
Build 54139: arc lint + arc unit

Event Timeline

khng requested review of this revision.Apr 19 2024, 10:29 PM
sys/kern/subr_asan.c
434

I'd prefer a more generic name, like kasan_kstack_init().

Or, follow the pattern of KMSAN and have kasan_thread_alloc() which only zeros the shadow of the stack (if td->td_kstack != 0).

Adapt markj@'s suggestions.

khng marked an inline comment as done.Apr 20 2024, 9:29 PM
sys/kern/subr_asan.c
434

Sorry, by "follow the pattern of KMSAN" I meant that kmsan_thread_alloc() and kasan_thread_alloc() calls should be in the same place. Otherwise it's rather confusing.

We can actually remove the shadow space marking in vm_thread_new() as well. I posted a diff to this effect: https://reviews.freebsd.org/D44891