Page MenuHomeFreeBSD

ahc(4)/ahd(4): fix target mode on ARM
ClosedPublic

Authored by kevans on Apr 19 2024, 2:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 4, 3:27 AM
Unknown Object (File)
Tue, May 21, 11:55 PM
Unknown Object (File)
Tue, May 21, 11:55 PM
Unknown Object (File)
Tue, May 21, 11:18 PM
Unknown Object (File)
May 15 2024, 2:49 AM
Unknown Object (File)
May 11 2024, 5:38 PM
Unknown Object (File)
May 3 2024, 6:36 PM
Unknown Object (File)
Apr 21 2024, 6:00 PM
Subscribers

Details

Summary

One of the comments in ahc_execute_scb() notes that the CAM direction is
actually w.r.t. the initiator. As a consequence, all of our sync ops
end up being wrong because the direction is flipped from that of the
transfer. Fix it to do proper invalidation and avoid spewing random
garbage out on the SCSI bus.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57208
Build 54096: arc lint + arc unit

Event Timeline

kevans created this revision.
This revision is now accepted and ready to land.Apr 19 2024, 2:11 AM

I have tested this on an Raspberry PI CM4 with the IO board and this works there.

Looks good to me, but if you wish, couple cosmetic thoughts.

sys/dev/aic7xxx/aic7xxx_osm.c
306

post asks to be bool, but considering age of the driver...

309

flags in struct ccb_hdr is uint32_t.

This revision was automatically updated to reflect the committed changes.