Page MenuHomeFreeBSD

ahc(4): resolve some minor nits
ClosedPublic

Authored by kevans on Apr 19 2024, 2:05 AM.
Tags
None
Referenced Files
F85942862: D44859.diff
Thu, Jun 13, 12:43 AM
Unknown Object (File)
Sun, May 26, 8:18 PM
Unknown Object (File)
Thu, May 23, 10:58 AM
Unknown Object (File)
Tue, May 21, 11:55 PM
Unknown Object (File)
Tue, May 21, 11:55 PM
Unknown Object (File)
Tue, May 21, 11:18 PM
Unknown Object (File)
Mon, May 20, 10:47 AM
Unknown Object (File)
May 3 2024, 9:42 AM
Subscribers
None

Details

Summary

In ahc_init(), qoutfifo is already assigned to effectively the same
value a couple lines up, except in the first assignment it uses the
proper definition; keep the more descriptive assignment.

ahc_targetcmd_offset() gets the offset wrong entirely; as per the
area of ahc_init() this diff also touches, targetcmds is laid out first
in the shared map and it's followed by the qoutfifo. As a result, we'd
generally be getting negative offsets here. We can't actually do a
partial sync anyways, so there was no consequence to getting this wrong.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.

I think this is good... but mav will know for sure if we're missing something

This revision is now accepted and ready to land.Apr 19 2024, 2:12 AM

Looks good to me, though seems only cosmetic.

This revision was automatically updated to reflect the committed changes.