Page MenuHomeFreeBSD

Fix build with WITH_NVME newly enabled
ClosedPublic

Authored by brooks on Apr 17 2024, 11:53 PM.
Tags
None
Referenced Files
F171194733: D44826.id137303.diff
Wed, Sep 9, 10:28 AM
F171164854: D44826.diff
Wed, Sep 9, 4:07 AM
Unknown Object (File)
Sat, Sep 5, 2:21 PM
Unknown Object (File)
Sat, Sep 5, 12:05 PM
Unknown Object (File)
Sat, Sep 5, 2:55 AM
Unknown Object (File)
Fri, Sep 4, 9:16 PM
Unknown Object (File)
Thu, Sep 3, 12:23 PM
Unknown Object (File)
Thu, Sep 3, 5:16 AM
Subscribers
None

Details

Summary

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Fixes: 2fda3ab0ac19 WITH_NVME: Remove from broken.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

This is slightly too big of a hammer in that rescue.mk will also be regenerated if WITHOUT_NVME is set, but if it's on the way out that seems fine.

oh! That's the problem... I did a clean build and that's why I didn't see it...

Also, maybe we should regenerate it when certain options change...

This revision is now accepted and ready to land.Apr 18 2024, 3:49 AM