Page MenuHomeFreeBSD

Fix build with WITH_NVME newly enabled
ClosedPublic

Authored by brooks on Wed, Apr 17, 11:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 9:33 AM
Unknown Object (File)
Fri, Apr 26, 7:46 AM
Unknown Object (File)
Fri, Apr 19, 4:47 PM
Unknown Object (File)
Thu, Apr 18, 3:02 PM
Subscribers
None

Details

Summary

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Fixes: 2fda3ab0ac19 WITH_NVME: Remove from broken.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

This is slightly too big of a hammer in that rescue.mk will also be regenerated if WITHOUT_NVME is set, but if it's on the way out that seems fine.

oh! That's the problem... I did a clean build and that's why I didn't see it...

Also, maybe we should regenerate it when certain options change...

This revision is now accepted and ready to land.Thu, Apr 18, 3:49 AM