Page MenuHomeFreeBSD

Fix build with WITH_NVME newly enabled
ClosedPublic

Authored by brooks on Apr 17 2024, 11:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 8, 3:17 PM
Unknown Object (File)
Sun, Feb 8, 4:00 AM
Unknown Object (File)
Sat, Jan 31, 12:39 AM
Unknown Object (File)
Fri, Jan 30, 5:06 PM
Unknown Object (File)
Tue, Jan 20, 4:10 AM
Unknown Object (File)
Jan 9 2026, 6:01 PM
Unknown Object (File)
Dec 13 2025, 10:30 PM
Unknown Object (File)
Dec 5 2025, 11:11 PM
Subscribers
None

Details

Summary

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Fixes: 2fda3ab0ac19 WITH_NVME: Remove from broken.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

This is slightly too big of a hammer in that rescue.mk will also be regenerated if WITHOUT_NVME is set, but if it's on the way out that seems fine.

oh! That's the problem... I did a clean build and that's why I didn't see it...

Also, maybe we should regenerate it when certain options change...

This revision is now accepted and ready to land.Apr 18 2024, 3:49 AM