Page MenuHomeFreeBSD

heimdal: Add 64-bit integer support to ASN.1 compiler
AbandonedPublic

Authored by dim on Tue, Apr 16, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 7:57 PM
Unknown Object (File)
Sat, Apr 27, 12:20 AM
Unknown Object (File)
Fri, Apr 26, 5:14 AM
Unknown Object (File)
Fri, Apr 19, 5:48 PM
Subscribers

Details

Reviewers
emaste
cy
Summary

Import upstream 19d378f44:

ASN.1 INTEGERs will now compile to C int64_t or uint64_t, depending
on whether the constraint ranges include numbers that cannot be
represented in 32-bit ints and whether they include negative
numbers.

Template backend support included.  check-template is now built with
--template, so we know we're testing it.

Tests included.

This should ensure generated asn1 headers (cms_asn1.h, krb5_asn1.h etc)
are the same for 64-bit and 32-bit hosts. In particular, cross-building
i386 from amd64 should result in exactly the same asn1 headers as a
native i386 build.

Obtained from: upstream 19d378f44
MFC after: TBD

Test Plan

I have no idea how to do a kerberos regression test. There
seem to be none in our tree?

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 57129
Build 54017: arc lint + arc unit

Event Timeline

dim requested review of this revision.Tue, Apr 16, 6:44 PM

Sorry about the "binary" files, but I couldn't convince arc to upload them otherwise. They aren't binary in my tree.

Abandon in favor of D44813 which might be easier to review.