Page MenuHomeFreeBSD
Differential D44553

sound: Make hw.snd.basename_clone a bool
AbandonedPublic
Actions

Authored by christos on Mar 29 2024, 4:02 AM.

Details

Reviewers
markj
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56826
Build 53714: arc lint + arc unit

Event Timeline

christos created this revision.Mar 29 2024, 4:02 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 29 2024, 4:02 AM
christos requested review of this revision.Mar 29 2024, 4:02 AM
Harbormaster completed remote builds in B56826: Diff 136320.Mar 29 2024, 4:02 AM
christos added a child revision: D44554: sound: Remove unused SND_DEV_LAST and SND_DEV_MAX constants.Mar 29 2024, 4:02 AM
markj added a comment.Mar 29 2024, 2:32 PM

Isn't this backwards incompatible? If a caller sets the sysctl in C, they'll have to change the type of the variable that they use. Existing code will misbehave.

christos abandoned this revision.Mar 29 2024, 3:19 PM
In D44553#1015947, @markj wrote:

Isn't this backwards incompatible? If a caller sets the sysctl in C, they'll have to change the type of the variable that they use. Existing code will misbehave.

Yes, I had forgot about this, my bad. Abandoning.

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
4 lines

Diff 136320

View Options

sys/dev/sound/pcm/dsp.c

Loading...