Page MenuHomeFreeBSD

daemon(8): handle case of waitpid() returning without exited child
ClosedPublic

Authored by kib on Mar 18 2024, 8:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 4, 1:51 AM
Unknown Object (File)
Mon, Jun 3, 10:45 AM
Unknown Object (File)
Fri, May 31, 4:55 PM
Unknown Object (File)
May 4 2024, 10:42 AM
Unknown Object (File)
Apr 30 2024, 5:33 PM
Unknown Object (File)
Apr 30 2024, 5:33 PM
Unknown Object (File)
Apr 30 2024, 5:33 PM
Unknown Object (File)
Apr 28 2024, 1:26 AM

Details

Summary

Not checking for either WIFEXITED(status) or zero result results in never finishing the loop.

PR: 277764

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Mar 18 2024, 8:49 AM
This revision is now accepted and ready to land.Mar 18 2024, 2:41 PM

Oh, return () style differs here

tamelingdaniel_gmail.com added inline comments.
usr.sbin/daemon/daemon.c
767

I think you also need to check WIFSIGNALED(status). Otherwise daemon will not finish when the child is killed by a signal.

Check for WIFSIGNALLED.
Un-style return.

This revision now requires review to proceed.Mar 18 2024, 6:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2024, 1:07 AM
This revision was automatically updated to reflect the committed changes.