Page MenuHomeFreeBSD
Differential D44357

uart: Split out initilisation of the acpi devinfo
ClosedPublic
Actions

Authored by andrew on Mar 14 2024, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 28, 11:25 PM
Unknown Object (File)
Tue, Aug 25, 4:18 PM
Unknown Object (File)
Thu, Aug 20, 7:18 PM
Unknown Object (File)
Sun, Aug 16, 2:27 PM
Unknown Object (File)
Sat, Aug 15, 6:32 AM
Unknown Object (File)
Thu, Aug 13, 2:41 PM
Unknown Object (File)
Wed, Aug 12, 10:43 PM
Unknown Object (File)
Tue, Aug 11, 12:34 PM
View All Files
Subscribers
None

Details

Reviewers
cperciva
imp
Commits
rGe4f74109173e: uart: Split out initilisation of the acpi devinfo
rGf48bd7527bba: uart: Split out initilisation of the acpi devinfo
rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo
Summary

Split out the common parts of building the uart devinfo from ACPI
tables from the SPCR parser. This will be used when we support the DBG2
table to find the debug uart to be used by the kernel gdb stub.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Mar 14 2024, 4:49 PM
andrew created this revision.
Harbormaster completed remote builds in B56603: Diff 135754.Mar 14 2024, 4:49 PM
andrew added a child revision: D44358: uart: Add uart_cpu_acpi_setup to setup the uart.Mar 14 2024, 4:50 PM
imp accepted this revision.Mar 14 2024, 5:53 PM

just one (possibly unrelated) question.

sys/dev/uart/uart_cpu_acpi.c
130

surely this should be 4? I know this is already there, but it looks out of place.

This revision is now accepted and ready to land.Mar 14 2024, 5:53 PM
andrew added inline comments.Mar 14 2024, 5:59 PM
sys/dev/uart/uart_cpu_acpi.c
130

It's a shift, so 1<<3 is 8 bytes or 64 bits

Closed by commit rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo (authored by andrew). · Explain WhyMar 18 2024, 4:38 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG473c0b44ae8c: uart: Split out initilisation of the acpi devinfo.
andrew added a commit: rGf48bd7527bba: uart: Split out initilisation of the acpi devinfo.Sep 2 2024, 8:51 AM
andrew added a commit: rGe4f74109173e: uart: Split out initilisation of the acpi devinfo.Sep 2 2024, 9:12 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
uart/
86 lines

Diff 135893

View Options

sys/dev/uart/uart_cpu_acpi.c

Loading...