Page MenuHomeFreeBSD

graphics/khronos-texture: new port - required for games/lwjgl3
ClosedPublic

Authored by vvd on Feb 27 2024, 7:18 PM.
Tags
Referenced Files
F86829372: D44120.diff
Wed, Jun 26, 5:25 AM
Unknown Object (File)
Sun, Jun 23, 11:30 AM
Unknown Object (File)
May 20 2024, 12:25 AM
Unknown Object (File)
May 20 2024, 12:25 AM
Unknown Object (File)
May 19 2024, 5:32 PM
Unknown Object (File)
May 16 2024, 6:38 AM
Unknown Object (File)
May 16 2024, 6:38 AM
Unknown Object (File)
May 16 2024, 6:38 AM
Subscribers
None

Details

Summary

This port required for build lwjgl 3, and lwjgl 3 required for Java Minecraft Client 1.20.x run on FreeBSD without linux compatibility layer.

Tested build in poudriere and in live system 13.2-p10 amd64.
Also test build lwjgl 3.

Some details are here: https://github.com/LWJGL/lwjgl3/issues/421#issuecomment-1964114740
https://github.com/KhronosGroup/KTX-Software/issues/786#issuecomment-1966884969

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Feb 27 2024, 7:18 PM
vvd created this revision.
graphics/khronos-texture/Makefile
16

I see you patched out all usages of fmt. Why link to it then?

vvd marked an inline comment as done.Feb 27 2024, 9:25 PM
vvd added inline comments.
graphics/khronos-texture/Makefile
16

By default it use embedded libfmt, link static with it, but install libfmt.a and includes from embedded libfmt - conflict with devel/libfmt.
That's why I turn off embedded libfmt and link dynamically with devel/libfmt.

vvd marked an inline comment as done.Feb 27 2024, 9:28 PM

Upstream suggest a better way to prevent install conflict with devel/libfmt: https://github.com/KhronosGroup/KTX-Software/issues/786#issuecomment-1972410244

Probably it will be integrated in upstream soon: https://github.com/KhronosGroup/KTX-Software/issues/865

graphics/khronos-texture/files/patch-CMakeLists.txt
7 ↗(On Diff #135254)

Can't this patch be replaced with CMAKE_OFF= FMT_INSTALL in the Makefile?

graphics/khronos-texture/files/patch-CMakeLists.txt
7 ↗(On Diff #135254)

My bad…
Ofc can and I tested it! :-D
But posted patch same as for upstream. :-o

graphics/khronos-texture/Makefile
21

This can probably be removed if you use DISTVERSIONPREFIX=v.

graphics/khronos-texture/Makefile
21

DISTVERSIONPREFIX=v work - just tested.
Same as DISTVERSIONPREFIX=vulkan-sdk- for graphics/spirv-cross and DISTVERSIONPREFIX=release- for graphics/openxr.
Should I change this in all 3 ports?

graphics/khronos-texture/Makefile
21

Yes, AFAIK this is more canonical than GH_TAGNAME.

vvd marked 2 inline comments as done.Mar 1 2024, 4:27 PM
vvd added inline comments.
graphics/khronos-texture/Makefile
21

Done.

vvd marked an inline comment as done.Mar 1 2024, 4:28 PM
This revision is now accepted and ready to land.Mar 1 2024, 4:34 PM