Page MenuHomeFreeBSD
Differential D43816

VFS: update VOP_FSYNC() debug check to reflect actual locking policy
ClosedPublic
Actions

Authored by jah on Feb 10 2024, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 5, 11:10 PM
Unknown Object (File)
Fri, Oct 2, 10:20 PM
Unknown Object (File)
Mon, Sep 28, 2:35 PM
Unknown Object (File)
Sun, Sep 27, 2:14 PM
Unknown Object (File)
Fri, Sep 25, 5:56 PM
Unknown Object (File)
Fri, Sep 25, 5:54 PM
Unknown Object (File)
Fri, Sep 25, 3:32 PM
Unknown Object (File)
Sat, Sep 12, 8:12 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
olce
Commits
rGd0bb255d1fcb: VFS: update VOP_FSYNC() debug check to reflect actual locking policy
rG9530182e371d: VFS: update VOP_FSYNC() debug check to reflect actual locking policy
Summary

Shared vs. exclusive locking is determined not by MNT_EXTENDED_SHARED
but by MNT_SHARED_WRITES (although there are several places that
ignore this and simply always use an exclusive lock). Also add a
comment on the possible difference between VOP_GETWRITEMOUNT(vp)
and vp->v_mount on this path.

Found by local testing of unionfs atop ZFS with DEBUG_VFS_LOCKS.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
kern/
17 lines

Diff 134565

View Options

sys/kern/vfs_subr.c

Loading...