Page MenuHomeFreeBSD

libcuse: Fix memory leak in cuse_init()
Needs ReviewPublic

Authored by zlei on Feb 5 2024, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 10, 12:37 AM
Unknown Object (File)
Sun, May 10, 12:29 AM
Unknown Object (File)
Tue, Apr 28, 9:21 PM
Unknown Object (File)
Tue, Apr 28, 9:13 PM
Unknown Object (File)
Mon, Apr 27, 9:37 PM
Unknown Object (File)
Tue, Apr 14, 6:42 PM
Unknown Object (File)
Tue, Apr 14, 3:24 AM
Unknown Object (File)
Mar 17 2026, 1:33 AM
Subscribers

Details

Reviewers
kib
markj
Summary

The mutex attributes object should be destroyed after been used.

Where here also check return value of pthread_mutexattr_init() to
prevent potential writing in unallocated memory or NULL pointer
dereferencing when the system is out of memory.

This fix is inspired by the recent commit a03f768612ad
(libstdthreads: destroy mutexattr in mtx_init()) .

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Feb 5 2024, 6:48 AM
lib/libcuse/cuse_lib.c
113

Emm, return value of pthread_mutex_init() is not checked ;(