Page MenuHomeFreeBSD

libcuse: Fix memory leak in cuse_init()
Needs ReviewPublic

Authored by zlei on Feb 5 2024, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 17, 1:33 AM
Unknown Object (File)
Mar 11 2026, 1:18 AM
Unknown Object (File)
Mar 9 2026, 2:07 PM
Unknown Object (File)
Mar 9 2026, 8:26 AM
Unknown Object (File)
Feb 22 2026, 12:31 AM
Unknown Object (File)
Feb 21 2026, 11:10 PM
Unknown Object (File)
Feb 16 2026, 12:45 PM
Unknown Object (File)
Feb 4 2026, 1:39 AM
Subscribers

Details

Reviewers
kib
markj
Summary

The mutex attributes object should be destroyed after been used.

Where here also check return value of pthread_mutexattr_init() to
prevent potential writing in unallocated memory or NULL pointer
dereferencing when the system is out of memory.

This fix is inspired by the recent commit a03f768612ad
(libstdthreads: destroy mutexattr in mtx_init()) .

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Feb 5 2024, 6:48 AM
lib/libcuse/cuse_lib.c
113

Emm, return value of pthread_mutex_init() is not checked ;(