Page MenuHomeFreeBSD

libcuse: Fix memory leak in cuse_init()
Needs ReviewPublic

Authored by zlei on Feb 5 2024, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 12:20 PM
Unknown Object (File)
Mon, Sep 7, 12:08 PM
Unknown Object (File)
Sun, Sep 6, 2:27 PM
Unknown Object (File)
Wed, Sep 2, 11:49 PM
Unknown Object (File)
Mon, Aug 31, 9:30 AM
Unknown Object (File)
Wed, Aug 26, 12:35 PM
Unknown Object (File)
Jul 27 2026, 2:11 PM
Unknown Object (File)
Jul 26 2026, 3:48 PM
Subscribers

Details

Reviewers
kib
markj
Summary

The mutex attributes object should be destroyed after been used.

Where here also check return value of pthread_mutexattr_init() to
prevent potential writing in unallocated memory or NULL pointer
dereferencing when the system is out of memory.

This fix is inspired by the recent commit a03f768612ad
(libstdthreads: destroy mutexattr in mtx_init()) .

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Feb 5 2024, 6:48 AM
lib/libcuse/cuse_lib.c
113

Emm, return value of pthread_mutex_init() is not checked ;(