Page MenuHomeFreeBSD

libcuse: Fix memory leak in cuse_init()
Needs ReviewPublic

Authored by zlei on Feb 5 2024, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 10, 12:42 AM
Unknown Object (File)
Tue, Dec 2, 11:43 AM
Unknown Object (File)
Fri, Nov 28, 2:03 AM
Unknown Object (File)
Oct 29 2025, 9:45 AM
Unknown Object (File)
Oct 29 2025, 8:51 AM
Unknown Object (File)
Oct 14 2025, 1:53 PM
Unknown Object (File)
Oct 14 2025, 1:53 PM
Unknown Object (File)
Oct 14 2025, 12:07 AM
Subscribers

Details

Reviewers
kib
markj
Summary

The mutex attributes object should be destroyed after been used.

Where here also check return value of pthread_mutexattr_init() to
prevent potential writing in unallocated memory or NULL pointer
dereferencing when the system is out of memory.

This fix is inspired by the recent commit a03f768612ad
(libstdthreads: destroy mutexattr in mtx_init()) .

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.Feb 5 2024, 6:48 AM
lib/libcuse/cuse_lib.c
113

Emm, return value of pthread_mutex_init() is not checked ;(