linuxkpi: remove invalid KASSERT from hash_add_rcu
ClosedPublic
Actions

Authored by emaste on Jan 29 2024, 2:28 PM.

Details

Reviewers

bz
manu

Group Reviewers

linuxkpi

Commits

rG495bdd698e42: linuxkpi: remove invalid KASSERT from hash_add_rcu
rG7e77089dccd7: linuxkpi: remove invalid KASSERT from hash_add_rcu

Summary

hash_add_rcu asserted that the node's prev pointer was NULL in an
attempt to detect addition of a node already on a list, but the caller
is not required to provide a zeroed node.

Reported in https://github.com/freebsd/drm-kmod/issues/282

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jan 29 2024, 2:28 PM

emaste created this revision.

bz accepted this revision as: bz.Jan 29 2024, 2:59 PM

This revision is now accepted and ready to land.Jan 29 2024, 2:59 PM

manu accepted this revision.Jan 29 2024, 3:08 PM

Closed by commit rG7e77089dccd7: linuxkpi: remove invalid KASSERT from hash_add_rcu (authored by emaste). · Explain WhyJan 29 2024, 4:41 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG7e77089dccd7: linuxkpi: remove invalid KASSERT from hash_add_rcu.

Herald added a subscriber: imp. · View Herald TranscriptJan 29 2024, 4:41 PM

emaste added a commit: rG495bdd698e42: linuxkpi: remove invalid KASSERT from hash_add_rcu.Mar 25 2024, 10:32 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

hashtable.h

2 lines

Diff 133504

View Options

sys/compat/linuxkpi/common/include/linux/hashtable.h

linuxkpi: remove invalid KASSERT from hash_add_rcuClosedPublicActions