Page MenuHomeFreeBSD
Differential D43644

LinuxKPI: implement memset_after()
ClosedPublic
Actions

Authored by bz on Jan 29 2024, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 6:07 PM
Unknown Object (File)
Sat, Feb 22, 2:34 PM
Unknown Object (File)
Sat, Feb 22, 1:59 PM
Unknown Object (File)
Sat, Feb 22, 1:57 PM
Unknown Object (File)
Feb 13 2025, 8:04 AM
Unknown Object (File)
Feb 3 2025, 4:50 PM
Unknown Object (File)
Jan 24 2025, 9:21 PM
Unknown Object (File)
Dec 2 2024, 5:16 AM
View All 76 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG1bd05bae9252: LinuxKPI: implement memset_after()
rG7117d4b22f74: LinuxKPI: implement memset_after()
rG2d9d35837d8e: LinuxKPI: implement memset_after()
Summary

memset_after() is needed by iwlwifi d3.c.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
8 lines

Diff 133792

View Options

sys/compat/linuxkpi/common/include/linux/string.h

  • This file was added.
.\" Copyright (c) 2021 The FreeBSD Foundation
.\"
.\" This document was written by Ed Maste under sponsorhip from
.\" The FreeBSD Foundation.
.\"
.\" Redistribution and use in source and binary forms, with or without
.\" modification, are permitted provided that the following conditions
.\" are met:
.\" 1. Redistributions of source code must retain the above copyright
.\" notice, this list of conditions and the following disclaimer.
.\" 2. Redistributions in binary form must reproduce the above copyright
.\" notice, this list of conditions and the following disclaimer in the
.\" documentation and/or other materials provided with the distribution.
.\"
.\" THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
.\" IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
.\" OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
.\" IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
.\" INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
.\" NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
.\" DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
.\" THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
.\" THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
.\"
.\" $FreeBSD$
.\"
.Dd August 16, 2021
.Dt GONE_IN 9
.Os
.Sh NAME
.Nm gone_in ,
.Nm gone_in_dev
.Nd deprecation notice functions
.Sh SYNOPSIS
.In sys/systm.h
.Ft void
.Fn gone_in "int major" "const char *msg"
.Ft void
.Fn gone_in_dev "device_t dev" "int major" "const char *msg"
.Sh DESCRIPTION
The
.Fn gone_in
functions are used to provide a notice that the kernel is using a driver or
some other functionality that is deprecated, and will be removed in a future
.Fx
release.
The notice is sent to the kernel
.Xr dmesg 8
log and will appear on the console.
The
.Fa major
argument specifies the major version of the
debdrupUnsubmitted
Done
Inline Actions
.Fa major
- argument specifies the major version of the FreeBSD release that will remove
+ argument specifies the major version of the
+ .Fx
+ release that will remove
the deprecated functionality.
debdrup:
.Fx
release that will remove the deprecated functionality.
.Pp
In releases before
.Fa major
the deprecation notice states
.Do
debdrupUnsubmitted
Not Done
Inline Actions
the deprecation notice states
.Do
- Deprecated code (to be removed in FreeBSD
+ Deprecated code (to be removed in
+ .Fx
.Fa major ):
debdrup:
emasteAuthorUnsubmitted
Done
Inline Actions

I think this one probably should not change because it's literal console output.

emaste: I think this one probably should not change because it's literal console output.
Deprecated code (to be removed in FreeBSD
.Fa major Ns ):
emasteAuthorUnsubmitted
Done
Inline Actions

Added Ns here

emaste: Added Ns here
.Fa msg
.Dc .
In releases equal to and after
.Fa major
the notice states
.Do
Obsolete code will be removed soon:
.Fa msg
.Dc .
.Sh EXAMPLES
.Bd -literal -offset indent
void
sample_init(void)
{
/* Initializaiton code omitted. */
impUnsubmitted
Not Done
Inline Actions

11.x ABI compat isn't the headlining reason to retire, necessarily.
In the past this has been more like "Giant locked filesystem" or "Driver not migrated from old API" or simiar

imp: 11.x ABI compat isn't the headlining reason to retire, necessarily. In the past this has been…
emasteAuthorUnsubmitted
Done
Inline Actions

This was copied from an in-tree one, but indeed "Giant locked filesystem" is probably a good canonical example

emaste: This was copied from an in-tree one, but indeed "Giant locked filesystem" is probably a good…
gone_in(14, "Giant-locked filesystem");
}
impUnsubmitted
Done
Inline Actions

int

imp: int
int
example_driver_attach(struct example_driver_softc *sc)
{
impUnsubmitted
Not Done
Inline Actions

This message needs to be more along the lines of "This hardware no longer relevant to FreeBSD" or "This wifi driver doesn't support FooBar crypto" or some other minimum bar.

imp: This message needs to be more along the lines of "This hardware no longer relevant to FreeBSD"…
emasteAuthorUnsubmitted
Done
Inline Actions

Here's some examples from the tree, as they'd appear in dmesg:

Deprecated code (to be removed in FreeBSD 13): pccard removed, an doesn't support modern crypto
Deprecated code (to be removed in FreeBSD 13): pccard removed, an doesn't support modern crypto
Deprecated code (to be removed in FreeBSD 13): amr(4) driver
Deprecated code (to be removed in FreeBSD 13): FreeBSD 11.x ABI compat
Deprecated code (to be removed in FreeBSD 14): FreeBSD 12.x ABI compat
Deprecated code (to be removed in FreeBSD 13): drm2 drivers
Deprecated code (to be removed in FreeBSD 14): esp(4) driver
Deprecated code (to be removed in FreeBSD 14): PC Card to be removed
Deprecated code (to be removed in FreeBSD 14): mly(4) removed
prefixed with the device name/number for gone_in_dev of course

IMO something short like "ISA drivers", "obsolete hardware" etc. is what we should suggest

sys/dev/mly/mly.c
339: gone_in_dev(dev, 13, "");

sys/dev/twa/tw_osl_freebsd.c
416: gone_in_dev(dev, 13, "twa(4) removed");

sys/dev/iir/iir_pci.c
339: gone_in_dev(dev, 13, "iir(4) removed");

emaste: Here's some examples from the tree, as they'd appear in dmesg: Deprecated code (to be removed…
/* Attach code omitted. */
gone_in_dev(sc->dev, 14, "Giant-locked driver");
}
.Ed
.Sh HISTORY
The
impUnsubmitted
Done
Inline Actions

11

imp: 11
.Nm
functions first appeared in
.Fx 11 .