Page MenuHomeFreeBSD

rc.d/kdc: Support start of MIT krb5kdc
ClosedPublic

Authored by cy on Jan 20 2024, 2:10 PM.
Tags
None
Referenced Files
F82741834: D43523.diff
Thu, May 2, 5:38 AM
Unknown Object (File)
Sat, Apr 27, 11:31 AM
Unknown Object (File)
Sat, Apr 27, 11:29 AM
Unknown Object (File)
Sat, Apr 27, 11:27 AM
Unknown Object (File)
Sat, Apr 27, 11:26 AM
Unknown Object (File)
Sat, Apr 27, 11:26 AM
Unknown Object (File)
Sat, Apr 27, 10:15 AM
Unknown Object (File)
Fri, Apr 19, 2:56 AM
Subscribers

Details

Summary

Some users wishing to use the MIT krb5kdc have discovered the
kdc script workaround applied to the MIT krb5 ports is insufficient.
Let's build into this rc script the smarts to determine whether
base or ports Hiemdal kdc is being invoked or the MIT krb5kdc.

Suggested by: netchild
Original patch: netchild
MFC after: 1 week

Test Plan

Will run it here for a few days.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy requested review of this revision.Jan 20 2024, 2:10 PM

Looks reasonable to me, line is longer than 80 cols though

This revision is now accepted and ready to land.Jan 20 2024, 7:42 PM
libexec/rc/rc.d/kdc
19–25

You can get rid of the kdc_start_precmd() completely. You want to make sure kdc_program is set (all config files loaded), so I would move the check to after load_rc_config. This would also make my patch in progress for service jails more easy, as it needs to get rid of the precmd anyway to work for the kdc.

Additionally to my suggested edit, you need to remove the "start_precmd=${name}_start_precmd" line.

Prepare for service jail patch.

This revision now requires review to proceed.Jan 21 2024, 5:31 AM
This revision is now accepted and ready to land.Jan 21 2024, 3:28 PM
This revision was automatically updated to reflect the committed changes.
cy marked an inline comment as done.