Page MenuHomeFreeBSD

git-arc: Retain color status messages
ClosedPublic

Authored by imp on Jan 15 2024, 5:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 15 2024, 7:36 PM
Unknown Object (File)
May 12 2024, 2:18 PM
Unknown Object (File)
May 12 2024, 2:17 PM
Unknown Object (File)
May 11 2024, 2:49 AM
Unknown Object (File)
May 10 2024, 5:17 PM
Unknown Object (File)
May 10 2024, 5:15 PM
Unknown Object (File)
Apr 20 2024, 4:47 PM
Unknown Object (File)
Apr 20 2024, 4:46 PM
Subscribers
None

Details

Summary

Newer versions of archanist have an --ansi option to always include the
ansi colors when doing an arc list (or any command really). Add this to
the arc list that's relevant. Add filter to filter out the 'bolding'
though since that interferes with our parsing. This should restore the
color output after df834e06bbc7.

Fixes: df834e06bbc7
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 15 2024, 5:26 PM
imp created this revision.

Don't we still need to strip all sequences when using arc_list in title2diff()?

Don't we still need to strip all sequences when using arc_list in title2diff()?

It works for me if I don't., but now I'm thinking that it may make sense to add a --no-ansi since john's and my experience with the same rev is so different.

Be explicit when we do or don't need to filter

It worked without the --no-ansi, let's see if this makes @jhb happy too.

fix alignment issue with git arc list for revisions with no review

In D43459#990757, @imp wrote:

fix alignment issue with git arc list for revisions with no review

well, fix until review D100000 ...

This revision is now accepted and ready to land.Jan 16 2024, 1:48 PM

s/archanist/arcanist/ in the commit log

This revision was automatically updated to reflect the committed changes.