Page MenuHomeFreeBSD

fusefs: fix an interaction between copy_file_range and mmap
ClosedPublic

Authored by asomers on Jan 13 2024, 10:43 PM.
Tags
None
Referenced Files
F171149462: D43451.diff
Wed, Sep 9, 12:51 AM
Unknown Object (File)
Sun, Sep 6, 11:06 PM
Unknown Object (File)
Sat, Sep 5, 6:13 PM
Unknown Object (File)
Sat, Sep 5, 6:13 PM
Unknown Object (File)
Sat, Sep 5, 1:05 PM
Unknown Object (File)
Sat, Sep 5, 11:35 AM
Unknown Object (File)
Fri, Sep 4, 1:56 AM
Unknown Object (File)
Thu, Sep 3, 12:26 PM
Subscribers

Details

Summary

If a copy_file_range operation tries to read from a page that was
previously written via mmap, that page must be flushed first.

MFC after: 2 weeks

Test Plan

two test cases added to the fusefs test suite

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/fs/fuse/fuse_vnops.c
912

Indent is strange.

I suggest to use (newly added) vnode_pager_clear_sync() instead, I do not think that possible optimization of flushing a range is significant there.

  • Use vnode_pager_clean_sync
This revision is now accepted and ready to land.Jan 15 2024, 9:53 PM