Page MenuHomeFreeBSD
Differential D43449

condvar: Clean up condvar.h a bit
ClosedPublic
Actions

Authored by markj on Jan 13 2024, 9:11 PM.
Tags
None
Referenced Files
F163103054: D43449.diff
Mon, Jul 20, 2:50 AM
Unknown Object (File)
Mon, Jul 6, 11:11 AM
Unknown Object (File)
Fri, Jul 3, 6:06 AM
Unknown Object (File)
Fri, Jul 3, 4:40 AM
Unknown Object (File)
Thu, Jul 2, 11:29 PM
Unknown Object (File)
Thu, Jul 2, 9:13 PM
Unknown Object (File)
Thu, Jul 2, 1:57 AM
Unknown Object (File)
Jun 7 2026, 3:19 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG08dbe7213452: condvar: Clean up condvar.h a bit
rG604b80f152f2: condvar: Clean up condvar.h a bit
rG61b0092be751: condvar: Clean up condvar.h a bit
Summary
  • Remove a typedef that has been unused for a long time.
  • Remove a LOCORE guard. MI headers like condvar.h don't need such a guard in general.
  • Move a forward declaration into the _KERNEL block.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jan 13 2024, 9:11 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 13 2024, 9:11 PM
markj requested review of this revision.Jan 13 2024, 9:11 PM
Harbormaster completed remote builds in B55426: Diff 132738.Jan 13 2024, 9:11 PM
markj added a child revision: D43450: condvar: Fix a user-after-free in _cv_wait() when ktrace is enabled.Jan 13 2024, 9:11 PM
kib accepted this revision.Jan 13 2024, 9:15 PM
kib added inline comments.
sys/sys/condvar.h
55

This requires sys/types.h

This revision is now accepted and ready to land.Jan 13 2024, 9:15 PM
markj updated this revision to Diff 132742.Jan 13 2024, 9:40 PM

Include sys/types.h as well.

This revision now requires review to proceed.Jan 13 2024, 9:40 PM
Harbormaster completed remote builds in B55430: Diff 132742.Jan 13 2024, 9:41 PM
kib accepted this revision.Jan 13 2024, 9:44 PM
This revision is now accepted and ready to land.Jan 13 2024, 9:44 PM
Closed by commit rG61b0092be751: condvar: Clean up condvar.h a bit (authored by markj). · Explain WhyJan 15 2024, 6:08 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG61b0092be751: condvar: Clean up condvar.h a bit.
markj added a commit: rG604b80f152f2: condvar: Clean up condvar.h a bit.Jan 29 2024, 2:28 PM
markj added a commit: rG08dbe7213452: condvar: Clean up condvar.h a bit.

Revision Contents
Changeset List

PathSize
sys/
sys/
13 lines

Diff 132787

View Options

sys/sys/condvar.h

Loading...