Vendor Import: kyua from FreeBSD fork into src tree
ClosedPublic
Actions

Authored by bofh on Jan 2 2024, 4:22 AM.

Details

Reviewers

markj
brooks

Commits

rG5f174897f677: vendor/kyua: Update to snapshot 84c8ec8

Summary

This brings in the latest update of kyua from FreeBSD fork. This is not the merged patch. Merged patch will be tested and submitted after the commit.

Test Plan

git checkout vendor/kyua
git apply <patch>
git diff

This will have the tag vendor/kyua/84c8ec8

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bofh created this revision.Jan 2 2024, 4:22 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2024, 4:22 AM

bofh requested review of this revision.Jan 2 2024, 4:22 AM

This looks sane to me. I thought the diff would be larger but I guess not.

I noticed that kyua's own test suite is not hooked up to the build, which seems like a bug...

markj added a reviewer: brooks.Jan 2 2024, 5:14 AM

LTGM. Hopefully we can get kyua development moving a bit more soon.

.cirrus.yml
14	This all seems good, but unrelated?

This revision is now accepted and ready to land.Jan 3 2024, 4:26 PM

In D43268#986194, @markj wrote:

I noticed that kyua's own test suite is not hooked up to the build, which seems like a bug...

Yeah, it should be hooked up. I probably got demotivated by all the yelling about importing it and never finished that part.

brooks added inline comments.Jan 3 2024, 4:28 PM

.cirrus.yml
14	Oh, I see now. Never mind.

In D43268#986194, @markj wrote:

This looks sane to me. I thought the diff would be larger but I guess not.

Looks like the documentation in the Committers Guide about the Vendor Import is a bit out of date. But this should work

I noticed that kyua's own test suite is not hooked up to the build, which seems like a bug...

Did you mean the utils/process/executor_pid_test.cpp file is not hooked into the Makefile of the src tree? I plan to add this after the merge is completed.
Or do you make some changed to the upstream repo first?

In D43268#987010, @bofh wrote:

In D43268#986194, @markj wrote:

This looks sane to me. I thought the diff would be larger but I guess not.

Looks like the documentation in the Committers Guide about the Vendor Import is a bit out of date. But this should work

I noticed that kyua's own test suite is not hooked up to the build, which seems like a bug...

Did you mean the utils/process/executor_pid_test.cpp file is not hooked into the Makefile of the src tree? I plan to add this after the merge is completed.
Or do you make some changed to the upstream repo first?

I'm sorry, I missed this question. I meant that execute_pid_test.cpp is not hooked up to the src build, yes. In fact, none of the tests are hooked up. But that can be fixed later.

Thank you for working on this!

Closed by commit rG5f174897f677: vendor/kyua: Update to snapshot 84c8ec8 (authored by bofh). · Explain WhyJan 12 2024, 8:28 PM

This revision was automatically updated to reflect the committed changes.

bofh added a commit: rG5f174897f677: vendor/kyua: Update to snapshot 84c8ec8.