Page MenuHomeFreeBSD
Differential D43205

Convert fsidcmp(9) from macro to inline function
ClosedPublic
Actions

Authored by kib on Dec 27 2023, 2:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 22, 4:57 AM
Unknown Object (File)
Thu, May 21, 6:24 PM
Unknown Object (File)
Wed, May 20, 9:38 AM
Unknown Object (File)
Wed, May 20, 1:58 AM
Unknown Object (File)
Sun, May 17, 5:40 AM
Unknown Object (File)
Apr 27 2026, 10:28 PM
Unknown Object (File)
Apr 20 2026, 6:56 PM
Unknown Object (File)
Apr 20 2026, 6:41 PM
View All Files
Subscribers
imp

Details

Reviewers
zlei
markj
Commits
rG3334a537ed38: Convert fsidcmp(9) from macro to inline function
Summary
This allows type checking the arguments.

Explicit structure members comparisions are done to avoid introducting
string.h pollution for userspace.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Dec 27 2023, 2:51 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 27 2023, 2:51 AM
kib requested review of this revision.Dec 27 2023, 2:51 AM
markj added inline comments.Dec 27 2023, 3:27 AM
sys/sys/mount.h
57
kib updated this revision to Diff 131893.Dec 27 2023, 3:41 AM
kib marked an inline comment as done.

Fix silliness.

markj accepted this revision.Dec 27 2023, 3:58 AM
This revision is now accepted and ready to land.Dec 27 2023, 3:58 AM
Closed by commit rG3334a537ed38: Convert fsidcmp(9) from macro to inline function (authored by kib). · Explain WhyDec 27 2023, 10:05 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG3334a537ed38: Convert fsidcmp(9) from macro to inline function.

Revision Contents
Changeset List

PathSize
sys/
sys/
7 lines

Diff 131900

View Options

sys/sys/mount.h

Loading...