Page MenuHomeFreeBSD

multimedia/vlc: fix build with CHROMECAST ON and devel/protobuf 24 and fix plist error if QT5 on and xext,xinerama,xpm installed
ClosedPublic

Authored by vvd on Dec 19 2023, 10:08 PM.
Referenced Files
Unknown Object (File)
Sun, Jun 16, 5:30 AM
Unknown Object (File)
Sun, Jun 16, 5:25 AM
Unknown Object (File)
Sun, Jun 16, 5:25 AM
Unknown Object (File)
Sun, Jun 16, 5:21 AM
Unknown Object (File)
Sun, Jun 16, 5:13 AM
Unknown Object (File)
May 24 2024, 4:36 AM
Unknown Object (File)
May 17 2024, 6:25 PM
Unknown Object (File)
Apr 26 2024, 2:44 AM
Subscribers

Details

Summary
  1. CHROMECAST option require devel/protobuf.

After this commit https://cgit.freebsd.org/ports/commit/?id=69e2e87fa56b54e267429b326f7f6188a7baaa71 consumers require USE_CXXSTD=c++17.

  1. There is default on configure option "skins2". It require QT5 and xext,xinerama,xpm - if they installed then it build bin/svlc and it is in stage after build.

Added option SKINS default off to handle bin/svlc.

Tested in poudriere and in live system.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Dec 19 2023, 10:08 PM
vvd created this revision.
diizzy added inline comments.
multimedia/vlc/Makefile
34

In that case it should go under CHROMECAST for now?

multimedia/vlc/Makefile
34

Is any better way than:

.include <bsd.port.options.mk>

.if ${PORT_OPTIONS:MCHROMECAST}
USE_CXXSTD=	c++17
.endif

?
Didn't find examples in other ports.

multimedia/vlc/Makefile
34

This way tested and vlc build fine with it.
Update patch?

arrowd requested changes to this revision.Dec 25 2023, 4:18 PM

This change looks very useful, thanks for figuring this out!

multimedia/vlc/Makefile
34
This revision now requires changes to proceed.Dec 25 2023, 4:18 PM
This revision is now accepted and ready to land.Dec 27 2023, 7:14 AM