hid: Handle errors from copyin() in ioctl handlers
ClosedPublic
Actions

Authored by markj on Dec 19 2023, 3:15 AM.

Details

Reviewers

Commits

rG7db5449ec5b1: hid: Handle errors from copyin() in ioctl handlers
rG4f1e5e94d4ac: hid: Handle errors from copyin() in ioctl handlers
rGe452fa70d507: hid: Handle errors from copyin() in ioctl handlers

Summary

If copyin() fails, the driver will proceed blindly with a zeroed buffer,
which is not what we want. In preparation for annotating copyin() with
__result_use_check, start checking for errors.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 19 2023, 3:15 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 19 2023, 3:15 AM

markj requested review of this revision.Dec 19 2023, 3:15 AM

Harbormaster completed remote builds in B55008: Diff 131553.Dec 19 2023, 3:15 AM

LGTM

This revision is now accepted and ready to land.Dec 19 2023, 7:18 PM

Closed by commit rGe452fa70d507: hid: Handle errors from copyin() in ioctl handlers (authored by markj). · Explain WhyDec 26 2023, 2:04 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe452fa70d507: hid: Handle errors from copyin() in ioctl handlers.

markj added a commit: rG4f1e5e94d4ac: hid: Handle errors from copyin() in ioctl handlers.Jan 2 2024, 12:38 AM

markj added a commit: rG7db5449ec5b1: hid: Handle errors from copyin() in ioctl handlers.Jan 2 2024, 1:14 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

hidraw.c

32 lines

Diff 131839

View Options

hid: Handle errors from copyin() in ioctl handlersClosedPublicActions